From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49383) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tj9Tb-0000hI-W2 for qemu-devel@nongnu.org; Thu, 13 Dec 2012 09:09:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tj9TV-0006Z5-TX for qemu-devel@nongnu.org; Thu, 13 Dec 2012 09:09:27 -0500 Received: from mail-da0-f45.google.com ([209.85.210.45]:44674) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tj9TV-0006Yh-N1 for qemu-devel@nongnu.org; Thu, 13 Dec 2012 09:09:21 -0500 Received: by mail-da0-f45.google.com with SMTP id w4so835161dam.4 for ; Thu, 13 Dec 2012 06:09:20 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <50C90B8D.3090801@gmail.com> References: <50C90B8D.3090801@gmail.com> Date: Thu, 13 Dec 2012 14:09:20 +0000 Message-ID: From: Peter Maydell Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH v4 0/6] hw/ds1338.c List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Antoine Mathys Cc: qemu-devel@nongnu.org, paul@codesourcery.com On 12 December 2012 22:56, Antoine Mathys wrote: > Empty cover letters rather defeat their purpose, by the way. git format-patch's --cover-letter option will generate you a nice cover letter template including a summary of the patches in the series and a diffstat. Anyway, all patches Reviewed-by: Peter Maydell and I've put them into arm-devs.next. Thanks! A couple of formatting points for future reference, if you want to send further patches to QEMU in the future: Your email client is sending patch emails with the 'format=flowed' attribute, which means that every line in the patch beginning with a space has an extra space added to it. That means that if I save the email or if I go and download the version from patchwork ( http://patchwork.ozlabs.org/patch/205677/ ) it won't apply. It is also wrapping long lines (as can be seen in patch 4/6. I fixed this up this time by running a sed command to fix up the mangled patchfiles, but it's much easier on reviewers if you can just send the patches as plain unmangled text (for example git format-patch and git send-email will send patches without mangling them.) thanks again -- PMM