From: Peter Maydell <peter.maydell@linaro.org>
To: kumar sourav <sourav.jb1988@gmail.com>
Cc: QEMU Trivial <qemu-trivial@nongnu.org>,
Joel Stanley <joel@jms.id.au>,
QEMU Developers <qemu-devel@nongnu.org>,
qemu-arm <qemu-arm@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] hw/arm/nrf51_soc: set object owner in memory_region_init_ram
Date: Tue, 29 Jan 2019 15:09:34 +0000 [thread overview]
Message-ID: <CAFEAcA-E=-6H340nhA258GkCbM2YC4=CxCRsBicanKJtEc7SXA@mail.gmail.com> (raw)
In-Reply-To: <20190125155630.17430-1-sourav.jb1988@gmail.com>
On Fri, 25 Jan 2019 at 15:56, kumar sourav <sourav.jb1988@gmail.com> wrote:
>
> set object owner in memory_region_init_ram() instead
> of NULL.
>
> Signed-off-by: kumar sourav <sourav.jb1988@gmail.com>
> ---
> hw/arm/nrf51_soc.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/hw/arm/nrf51_soc.c b/hw/arm/nrf51_soc.c
> index 1630c27594..3a1c7e200c 100644
> --- a/hw/arm/nrf51_soc.c
> +++ b/hw/arm/nrf51_soc.c
> @@ -89,7 +89,8 @@ static void nrf51_soc_realize(DeviceState *dev_soc, Error **errp)
> }
> memory_region_add_subregion(&s->container, NRF51_FLASH_BASE, &s->flash);
>
> - memory_region_init_ram(&s->sram, NULL, "nrf51.sram", s->sram_size, &err);
> + memory_region_init_ram(&s->sram, OBJECT(s), "nrf51.sram", s->sram_size,
> + &err);
> if (err) {
> error_propagate(errp, err);
> return;
Applied to target-arm.next, thanks.
-- PMM
next prev parent reply other threads:[~2019-01-29 15:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-25 15:56 [Qemu-devel] [PATCH] hw/arm/nrf51_soc: set object owner in memory_region_init_ram kumar sourav
2019-01-25 16:39 ` Philippe Mathieu-Daudé
2019-01-29 2:56 ` Stefan Hajnoczi
2019-01-29 15:09 ` Peter Maydell [this message]
2019-02-02 19:09 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA-E=-6H340nhA258GkCbM2YC4=CxCRsBicanKJtEc7SXA@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=joel@jms.id.au \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=sourav.jb1988@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).