Re: [PATCH] include/hw/hyperv: add QEMU_PACKED to uapi structs

[Peter Maydell <peter.maydell@linaro.org>]

On Mon, 23 Mar 2026 at 12:06, Magnus Kulke
<magnuskulke@linux.microsoft.com> wrote:
>
> The uapi definitions are marked with __packed hints in the kernel
> headers, since we want to keep the contract of the Microsoft Hypervisor
> ABI explicit, we should also added them in our vendored files, with a
> few notable exceptions where the attribute is a noop.
>
> Signed-off-by: Magnus Kulke <magnuskulke@linux.microsoft.com>
> ---
>  include/hw/hyperv/hvgdk_mini.h | 37 ++++++++++++++++++++++------------
>  include/hw/hyperv/hvhdk.h      | 14 +++++++------
>  2 files changed, 32 insertions(+), 19 deletions(-)
>
> diff --git a/include/hw/hyperv/hvgdk_mini.h b/include/hw/hyperv/hvgdk_mini.h
> index cb52cc9de2..7d7b2e9b36 100644
> --- a/include/hw/hyperv/hvgdk_mini.h
> +++ b/include/hw/hyperv/hvgdk_mini.h
> @@ -7,6 +7,8 @@
>  #ifndef HW_HYPERV_HVGDK_MINI_H
>  #define HW_HYPERV_HVGDK_MINI_H
>
> +#include "qemu/compiler.h"

osdep.h includes compiler.h, so it is always present for all C
files; you don't need to explicitly include it.

thanks
-- PMM