* [PATCH] hw/arm/pxa2xx: Do not wire up OHCI for PXA255
@ 2020-03-13 16:02 Guenter Roeck
2020-03-16 15:35 ` Peter Maydell
2020-03-17 11:19 ` Peter Maydell
0 siblings, 2 replies; 4+ messages in thread
From: Guenter Roeck @ 2020-03-13 16:02 UTC (permalink / raw)
To: Peter Maydell; +Cc: qemu-arm, qemu-devel, Guenter Roeck
PXA255 does not support a USB OHCI controller, so don't wire it up.
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
hw/arm/pxa2xx.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/hw/arm/pxa2xx.c b/hw/arm/pxa2xx.c
index 56a36202d7..336c9bad4a 100644
--- a/hw/arm/pxa2xx.c
+++ b/hw/arm/pxa2xx.c
@@ -2290,9 +2290,6 @@ PXA2xxState *pxa255_init(MemoryRegion *address_space, unsigned int sdram_size)
s->ssp[i] = (SSIBus *)qdev_get_child_bus(dev, "ssi");
}
- sysbus_create_simple("sysbus-ohci", 0x4c000000,
- qdev_get_gpio_in(s->pic, PXA2XX_PIC_USBH1));
-
s->pcmcia[0] = pxa2xx_pcmcia_init(address_space, 0x20000000);
s->pcmcia[1] = pxa2xx_pcmcia_init(address_space, 0x30000000);
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] hw/arm/pxa2xx: Do not wire up OHCI for PXA255
2020-03-13 16:02 [PATCH] hw/arm/pxa2xx: Do not wire up OHCI for PXA255 Guenter Roeck
@ 2020-03-16 15:35 ` Peter Maydell
2020-03-16 16:01 ` Guenter Roeck
2020-03-17 11:19 ` Peter Maydell
1 sibling, 1 reply; 4+ messages in thread
From: Peter Maydell @ 2020-03-16 15:35 UTC (permalink / raw)
To: Guenter Roeck; +Cc: qemu-arm, QEMU Developers
On Fri, 13 Mar 2020 at 16:02, Guenter Roeck <linux@roeck-us.net> wrote:
>
> PXA255 does not support a USB OHCI controller, so don't wire it up.
>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> hw/arm/pxa2xx.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/hw/arm/pxa2xx.c b/hw/arm/pxa2xx.c
> index 56a36202d7..336c9bad4a 100644
> --- a/hw/arm/pxa2xx.c
> +++ b/hw/arm/pxa2xx.c
> @@ -2290,9 +2290,6 @@ PXA2xxState *pxa255_init(MemoryRegion *address_space, unsigned int sdram_size)
> s->ssp[i] = (SSIBus *)qdev_get_child_bus(dev, "ssi");
> }
>
> - sysbus_create_simple("sysbus-ohci", 0x4c000000,
> - qdev_get_gpio_in(s->pic, PXA2XX_PIC_USBH1));
> -
> s->pcmcia[0] = pxa2xx_pcmcia_init(address_space, 0x20000000);
> s->pcmcia[1] = pxa2xx_pcmcia_init(address_space, 0x30000000);
>
How did you notice this bug? Was it just reading the code?
thanks
-- PMM
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] hw/arm/pxa2xx: Do not wire up OHCI for PXA255
2020-03-16 15:35 ` Peter Maydell
@ 2020-03-16 16:01 ` Guenter Roeck
0 siblings, 0 replies; 4+ messages in thread
From: Guenter Roeck @ 2020-03-16 16:01 UTC (permalink / raw)
To: Peter Maydell; +Cc: qemu-arm, QEMU Developers
On 3/16/20 8:35 AM, Peter Maydell wrote:
> On Fri, 13 Mar 2020 at 16:02, Guenter Roeck <linux@roeck-us.net> wrote:
>>
>> PXA255 does not support a USB OHCI controller, so don't wire it up.
>>
>> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>> ---
>> hw/arm/pxa2xx.c | 3 ---
>> 1 file changed, 3 deletions(-)
>>
>> diff --git a/hw/arm/pxa2xx.c b/hw/arm/pxa2xx.c
>> index 56a36202d7..336c9bad4a 100644
>> --- a/hw/arm/pxa2xx.c
>> +++ b/hw/arm/pxa2xx.c
>> @@ -2290,9 +2290,6 @@ PXA2xxState *pxa255_init(MemoryRegion *address_space, unsigned int sdram_size)
>> s->ssp[i] = (SSIBus *)qdev_get_child_bus(dev, "ssi");
>> }
>>
>> - sysbus_create_simple("sysbus-ohci", 0x4c000000,
>> - qdev_get_gpio_in(s->pic, PXA2XX_PIC_USBH1));
>> -
>> s->pcmcia[0] = pxa2xx_pcmcia_init(address_space, 0x20000000);
>> s->pcmcia[1] = pxa2xx_pcmcia_init(address_space, 0x30000000);
>>
>
> How did you notice this bug? Was it just reading the code?
>
I found that it was wired up and I tried to enable it from Linux, which failed.
After that, I dug up the chip manual and realized that the pxa255 hardware
does not support it.
Guenter
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] hw/arm/pxa2xx: Do not wire up OHCI for PXA255
2020-03-13 16:02 [PATCH] hw/arm/pxa2xx: Do not wire up OHCI for PXA255 Guenter Roeck
2020-03-16 15:35 ` Peter Maydell
@ 2020-03-17 11:19 ` Peter Maydell
1 sibling, 0 replies; 4+ messages in thread
From: Peter Maydell @ 2020-03-17 11:19 UTC (permalink / raw)
To: Guenter Roeck; +Cc: qemu-arm, QEMU Developers
On Fri, 13 Mar 2020 at 16:02, Guenter Roeck <linux@roeck-us.net> wrote:
>
> PXA255 does not support a USB OHCI controller, so don't wire it up.
>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> hw/arm/pxa2xx.c | 3 ---
> 1 file changed, 3 deletions(-)
>
Applied to target-arm.next, thanks.
-- PMM
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-03-17 11:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-13 16:02 [PATCH] hw/arm/pxa2xx: Do not wire up OHCI for PXA255 Guenter Roeck
2020-03-16 15:35 ` Peter Maydell
2020-03-16 16:01 ` Guenter Roeck
2020-03-17 11:19 ` Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).