From: Peter Maydell <peter.maydell@linaro.org>
To: BALATON Zoltan <balaton@eik.bme.hu>
Cc: Sebastian Bauer <mail@sebastianbauer.info>,
Magnus Damm <magnus.damm@gmail.com>,
QEMU Developers <qemu-devel@nongnu.org>,
Aurelien Jarno <aurelien@aurel32.net>,
Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [PATCH 2/4] sm501: Drop unneded variable
Date: Mon, 15 Jun 2020 15:50:44 +0100 [thread overview]
Message-ID: <CAFEAcA-Ez3dUHJsfjwFrKRh4zc3Nwp4=-7q9HjrjuGnYQHheEA@mail.gmail.com> (raw)
In-Reply-To: <7a818701887a77af17995aa062b37f92ffc3d2eb.1591471056.git.balaton@eik.bme.hu>
On Sat, 6 Jun 2020 at 20:22, BALATON Zoltan <balaton@eik.bme.hu> wrote:
>
> We don't need a separate variable to keep track if we allocated memory
> that needs to be freed as we can test the pointer itself.
>
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
> ---
> hw/display/sm501.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
next prev parent reply other threads:[~2020-06-15 14:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-06 19:17 [PATCH 0/4] More sm501 fixes and optimisations BALATON Zoltan
2020-06-06 19:17 ` [PATCH 1/4] sm501: Fix bounds checks BALATON Zoltan
2020-06-15 15:23 ` Peter Maydell
2020-06-15 16:40 ` BALATON Zoltan
2020-06-15 16:53 ` Peter Maydell
2020-06-15 17:43 ` BALATON Zoltan
2020-06-06 19:17 ` [PATCH 3/4] sm501: Ignore no-op blits BALATON Zoltan
2020-06-15 14:56 ` Peter Maydell
2020-06-15 15:14 ` BALATON Zoltan
2020-06-06 19:17 ` [PATCH 4/4] sm501: Optimise 1 pixel 2d ops BALATON Zoltan
2020-06-15 15:42 ` Peter Maydell
2020-06-15 17:00 ` BALATON Zoltan
2020-06-06 19:17 ` [PATCH 2/4] sm501: Drop unneded variable BALATON Zoltan
2020-06-15 14:50 ` Peter Maydell [this message]
2020-06-12 13:10 ` [PATCH 0/4] More sm501 fixes and optimisations BALATON Zoltan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA-Ez3dUHJsfjwFrKRh4zc3Nwp4=-7q9HjrjuGnYQHheEA@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=aurelien@aurel32.net \
--cc=balaton@eik.bme.hu \
--cc=kraxel@redhat.com \
--cc=magnus.damm@gmail.com \
--cc=mail@sebastianbauer.info \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).