From: Peter Maydell <peter.maydell@linaro.org>
To: Bastian Blank <bblank@thinkmo.de>, qemu-devel@nongnu.org
Subject: Re: [PATCH v2] linux-user: Use correct type for FIBMAP and FIGETBSZ emulation
Date: Tue, 28 Oct 2025 13:11:57 +0000 [thread overview]
Message-ID: <CAFEAcA-FdX1OwY07QSWfavJ9vQuyOhf2twOXY1GCREfER1_qHg@mail.gmail.com> (raw)
In-Reply-To: <l6slswtmabktu6g23so3sldafschilwbp3kqolny3lppjezosi@hn6ptmklek4q>
On Tue, 28 Oct 2025 at 12:58, Bastian Blank <bblank@thinkmo.de> wrote:
>
> Both the FIBMAP and FIGETBSZ ioctl get "int *" (pointer to 32bit
> integer) as argument, not "long *" as specified in qemu. Using the
> correct type makes the emulation work in cross endian context.
>
> Both ioctl does not seem to be documented. However the kernel
> implementation has always used "int *".
>
> Signed-off-by: Bastian Blank <waldi@debian.org>
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/3185
> ---
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
next prev parent reply other threads:[~2025-10-28 13:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-28 12:16 [PATCH v2] linux-user: Use correct type for FIBMAP and FIGETBSZ emulation Bastian Blank
2025-10-28 13:11 ` Peter Maydell [this message]
2025-10-28 13:47 ` Helge Deller
2025-10-28 13:55 ` Michael Tokarev
2025-10-29 7:43 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA-FdX1OwY07QSWfavJ9vQuyOhf2twOXY1GCREfER1_qHg@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=bblank@thinkmo.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).