From: Peter Maydell <peter.maydell@linaro.org>
To: "Michael W. Bombardieri" <mb@ii.net>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH]: Fix conditional compilation for OpenBSD
Date: Sun, 31 Mar 2013 00:48:04 +0000 [thread overview]
Message-ID: <CAFEAcA-FqoZZ47CORw_WWd+CwXtTp_7dkZS2thV_iLya6FO+BA@mail.gmail.com> (raw)
In-Reply-To: <20130331003229.GA9097@bom.nom.co>
On 31 March 2013 00:32, Michael W. Bombardieri <mb@ii.net> wrote:
> This morning I tried building Qemu 1.4.0 on my
> Lenovo ThinkPad T61 running OpenBSD/i386 5.1.
> The thread code didn't build due to a missing
> library function. Looking at the code, #if
> statements for NetBSD should also be followed
> for OpenBSD. Using the following patch I was
> able to build Qemu using clang 3.0 (gcc 4.2.1
> ran out of memory). Please consider committing
> this patch.
Hi Michael; thanks for the patch. However I think we should
fix this by having a configure check for sem_timedwait [or
whatever the functions we need are], rather than by piling
up another OS ifdef check.
(If you want to have a go at that it would probably be
useful to read the wiki.qemu.org page on submitting
patches; in particular without a Signed-off-by: line
we can't apply a patch at all.)
-- PMM
next prev parent reply other threads:[~2013-03-31 0:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-31 0:32 [Qemu-devel] [PATCH]: Fix conditional compilation for OpenBSD Michael W. Bombardieri
2013-03-31 0:48 ` Peter Maydell [this message]
2013-03-31 12:46 ` Michael W. Bombardieri
2013-03-31 13:36 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA-FqoZZ47CORw_WWd+CwXtTp_7dkZS2thV_iLya6FO+BA@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=mb@ii.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).