From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:60968) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UM6Rg-0004xs-6K for qemu-devel@nongnu.org; Sat, 30 Mar 2013 20:48:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UM6Rf-0005uC-3U for qemu-devel@nongnu.org; Sat, 30 Mar 2013 20:48:28 -0400 Received: from mail-la0-x22a.google.com ([2a00:1450:4010:c03::22a]:49664) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UM6Re-0005u0-SR for qemu-devel@nongnu.org; Sat, 30 Mar 2013 20:48:27 -0400 Received: by mail-la0-f42.google.com with SMTP id fe20so1332665lab.1 for ; Sat, 30 Mar 2013 17:48:25 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20130331003229.GA9097@bom.nom.co> References: <20130331003229.GA9097@bom.nom.co> From: Peter Maydell Date: Sun, 31 Mar 2013 00:48:04 +0000 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH]: Fix conditional compilation for OpenBSD List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael W. Bombardieri" Cc: qemu-devel@nongnu.org On 31 March 2013 00:32, Michael W. Bombardieri wrote: > This morning I tried building Qemu 1.4.0 on my > Lenovo ThinkPad T61 running OpenBSD/i386 5.1. > The thread code didn't build due to a missing > library function. Looking at the code, #if > statements for NetBSD should also be followed > for OpenBSD. Using the following patch I was > able to build Qemu using clang 3.0 (gcc 4.2.1 > ran out of memory). Please consider committing > this patch. Hi Michael; thanks for the patch. However I think we should fix this by having a configure check for sem_timedwait [or whatever the functions we need are], rather than by piling up another OS ifdef check. (If you want to have a go at that it would probably be useful to read the wiki.qemu.org page on submitting patches; in particular without a Signed-off-by: line we can't apply a patch at all.) -- PMM