From: Peter Maydell <peter.maydell@linaro.org>
To: Thomas Huth <thuth@redhat.com>
Cc: "Stefan Hajnoczi" <stefanha@gmail.com>,
"Michael Tokarev" <mjt@tls.msk.ru>,
qemu-devel@nongnu.org, qemu-trivial@nongnu.org,
qemu-stable@nongnu.org,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: Re: [PULL 02/13] hw/rdma/vmw/pvrdma_cmd: Use correct struct in query_port()
Date: Thu, 19 Oct 2023 15:41:15 +0100 [thread overview]
Message-ID: <CAFEAcA-Fu1SrkYzo_2A3R+QRcZsmeFt_zsj45dfSKJM3DyniVA@mail.gmail.com> (raw)
In-Reply-To: <3f804d1f-cb72-452c-83b2-80f57331d170@redhat.com>
On Wed, 11 Oct 2023 at 17:29, Thomas Huth <thuth@redhat.com> wrote:
>
> On 11/10/2023 17.38, Stefan Hajnoczi wrote:
> > The following CI failure has occurred:
> >
> > ../hw/rdma/vmw/pvrdma_cmd.c:144:59: error: implicit conversion from
> > enumeration type 'enum ibv_port_state' to different enumeration type
> > 'enum pvrdma_port_state' [-Werror,-Wenum-conversion]
> > resp->attrs.state = dev->func0->device_active ? attrs.state :
> > ~ ~~~~~~^~~~~
> > ../hw/rdma/vmw/pvrdma_cmd.c:146:33: error: implicit conversion from
> > enumeration type 'enum ibv_mtu' to different enumeration type 'enum
> > pvrdma_mtu' [-Werror,-Wenum-conversion]
> > resp->attrs.max_mtu = attrs.max_mtu;
> > ~ ~~~~~~^~~~~~~
> > ../hw/rdma/vmw/pvrdma_cmd.c:147:36: error: implicit conversion from
> > enumeration type 'enum ibv_mtu' to different enumeration type 'enum
> > pvrdma_mtu' [-Werror,-Wenum-conversion]
> > resp->attrs.active_mtu = attrs.active_mtu;
> > ~ ~~~~~~^~~~~~~~~~
> >
> > https://gitlab.com/qemu-project/qemu/-/jobs/5270666420
> >
> > Please take a look.
>
> That pvrdma patch unfortunately does not work with Clang, see also:
>
>
> https://lore.kernel.org/qemu-devel/781330fc-85b3-4ef1-8f07-1cc5fc5e4ad2@redhat.com/T/#t
Explicitly casting to the new enum type is OK and fixes the clang
warnings; I'll send out a v2 of the patch in a moment.
thanks
-- PMM
next prev parent reply other threads:[~2023-10-19 14:42 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-11 11:20 [PULL 00/13] Trivial patches for 2023-10-11 Michael Tokarev
2023-10-11 11:20 ` [PULL 01/13] Update AMD memory encryption document links Michael Tokarev
2023-10-11 11:20 ` [PULL 02/13] hw/rdma/vmw/pvrdma_cmd: Use correct struct in query_port() Michael Tokarev
2023-10-11 15:38 ` Stefan Hajnoczi
2023-10-11 16:29 ` Thomas Huth
2023-10-19 14:41 ` Peter Maydell [this message]
2023-10-11 11:20 ` [PULL 03/13] Fix compilation when UFFDIO_REGISTER is not set Michael Tokarev
2023-10-11 11:20 ` [PULL 04/13] MAINTAINERS: Add g364fb and ds1225y to the Jazz section Michael Tokarev
2023-10-11 11:20 ` [PULL 05/13] MAINTAINERS: Add unowned RISC-V related files to the right sections Michael Tokarev
2023-10-11 11:20 ` [PULL 06/13] MAINTAINERS: Add include folder to the hw/char/ section Michael Tokarev
2023-10-11 11:20 ` [PULL 07/13] MAINTAINERS: Add the CI-related doc files to the CI section Michael Tokarev
2023-10-11 11:20 ` [PULL 08/13] MAINTAINERS: add standard-headers to Hosts/LINUX Michael Tokarev
2023-10-11 11:20 ` [PULL 09/13] MAINTAINERS: Add section for overall sensors Michael Tokarev
2023-10-11 11:20 ` [PULL 10/13] MAINTAINERS: Add some unowned files to the SBSA-REF section Michael Tokarev
2023-10-11 11:20 ` [PULL 11/13] roms: use PYTHON to invoke python Michael Tokarev
2023-10-11 11:20 ` [PULL 12/13] scripts/xml-preprocess: Make sure this script is invoked via the right Python Michael Tokarev
2023-10-11 11:20 ` [PULL 13/13] cpus: Remove unused smp_cores/smp_threads declarations Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA-Fu1SrkYzo_2A3R+QRcZsmeFt_zsj45dfSKJM3DyniVA@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=mjt@tls.msk.ru \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=stefanha@gmail.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).