From: Peter Maydell <peter.maydell@linaro.org>
To: ChenQun <chenq009@gmail.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
"kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>
Subject: Re: [Qemu-devel] [PATCH] fix initrd load failed
Date: Sun, 17 Nov 2013 16:26:57 +0000 [thread overview]
Message-ID: <CAFEAcA-HKahbW=Ns2zZnRftWHSJSUp7nKDwByBLS+wihNrnucg@mail.gmail.com> (raw)
In-Reply-To: <1384704624-3860-1-git-send-email-chenq009@gmail.com>
On 17 November 2013 16:10, ChenQun <chenq009@gmail.com> wrote:
> Here's a bug, some examples are as follows:
> 1.Assuming Guest's filesystem size 6M.
> 2.For vexpress_a15, the loader_start = 2048M.
> If we set guest ram_size range from 2048M+128M to 2048M+128M+6M,
> then the initrd load failed.
> 3.For mach-virt, the loader_start = 128M.
> If we set guest ram_size range from 256M to 256M+6M, then it is
> failed too.
>
> So,it is a bug for load initrd max mem calculation.
> It should be (ram_size + loader_start - initrd_start).
Yes, this is definitely a bug. The set of addresses/sizes we
pass to the loader is a bit of a mess, though -- we kind of
implicitly assume that "loader_start" means "bottom of RAM",
and that all the ram is in one chunk. However for example
realview-pbx-a9 sets loader_start to 0 when the size of that
bit of RAM may be less than the total ram_size. The device
tree editing code also assumes a single contiguous block
of RAM...
thanks
-- PMM
prev parent reply other threads:[~2013-11-17 16:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-17 16:10 [Qemu-devel] [PATCH] fix initrd load failed ChenQun
2013-11-17 16:26 ` Peter Maydell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA-HKahbW=Ns2zZnRftWHSJSUp7nKDwByBLS+wihNrnucg@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=chenq009@gmail.com \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).