qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: qemu-arm <qemu-arm@nongnu.org>,
	QEMU Developers <qemu-devel@nongnu.org>,
	"patches@linaro.org" <patches@linaro.org>
Subject: Re: [Qemu-devel] [PATCH] target/arm: Make disas_thumb2_insn() generate its own UNDEF exceptions
Date: Tue, 9 Jan 2018 14:22:23 +0000	[thread overview]
Message-ID: <CAFEAcA-J4MwnyusPgB7V3LK2c4G-OCJx3ReVO27riM761mv9jg@mail.gmail.com> (raw)
In-Reply-To: <52515faf-f889-93ee-c0d0-4a895cfb6b13@linaro.org>

On 12 December 2017 at 17:39, Richard Henderson
<richard.henderson@linaro.org> wrote:
> On 12/12/2017 04:08 AM, Peter Maydell wrote:
>> Refactor disas_thumb2_insn() so that it generates the code for raising
>> an UNDEF exception for invalid insns, rather than returning a flag
>> which the caller must check to see if it needs to generate the UNDEF
>> code. This brings the function in to line with the behaviour of
>> disas_thumb_insn() and disas_arm_insn().
>>
>> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
>> ---
>> This fixes the odd asymmetry of API that caused the bug fixed
>> in commit 7472e2efb...
>> ---
>>  target/arm/translate.c | 23 ++++++++++-------------
>>  1 file changed, 10 insertions(+), 13 deletions(-)
>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

Thanks; applied to target-arm.next.

-- PMM

      reply	other threads:[~2018-01-09 14:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-12 12:08 [Qemu-devel] [PATCH] target/arm: Make disas_thumb2_insn() generate its own UNDEF exceptions Peter Maydell
2017-12-12 17:39 ` Richard Henderson
2018-01-09 14:22   ` Peter Maydell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFEAcA-J4MwnyusPgB7V3LK2c4G-OCJx3ReVO27riM761mv9jg@mail.gmail.com \
    --to=peter.maydell@linaro.org \
    --cc=patches@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).