From: Peter Maydell <peter.maydell@linaro.org>
To: Markus Armbruster <armbru@redhat.com>
Cc: "Daniel P. Berrange" <berrange@redhat.com>,
zhanghailiang <zhang.zhanghailiang@huawei.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"QEMU Trivial" <qemu-trivial@nongnu.org>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"Gan Qixin" <ganqixin@huawei.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Chenqun (kuhn)" <kuhn.chenqun@huawei.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: Re: [PATCH] scripts/checkpatch.pl: Modify the line length limit of the code
Date: Mon, 30 Nov 2020 13:26:11 +0000 [thread overview]
Message-ID: <CAFEAcA-JCLUn5BxwH71CmFB3Q+KMSK0pid8nGH9hLUokNcoLSw@mail.gmail.com> (raw)
In-Reply-To: <87mtzqsy2r.fsf@dusky.pond.sub.org>
On Mon, 9 Nov 2020 at 09:01, Markus Armbruster <armbru@redhat.com> wrote:
> CODING_STYLE.rst: "Lines should be 80 characters; try not to make them
> longer." I'd like to keep the tooling we have to help us with trying
> not to make them longer.
>
> If we have lost the ability to differentiate between "warning" and
> "error", call it something else.
Personally I just want checkpatch with its default arguments not
to complain about code that we'd be happy to accept in the tree.
It's unnecessary noise when I write and check the code locally,
when patchew runs on the patch on the list and then when it goes
into a pullreq. Do we need a new "be really strict" option?
thanks
-- PMM
next prev parent reply other threads:[~2020-11-30 13:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-05 15:42 [PATCH] scripts/checkpatch.pl: Modify the line length limit of the code Gan Qixin
2020-11-06 11:06 ` Peter Maydell
2020-11-06 13:07 ` Markus Armbruster
2020-11-06 13:39 ` Peter Maydell
2020-11-06 14:08 ` Philippe Mathieu-Daudé
2020-11-06 14:16 ` Peter Maydell
2020-11-06 14:49 ` Philippe Mathieu-Daudé
2020-11-06 16:08 ` Markus Armbruster
2020-11-06 16:19 ` Peter Maydell
2020-11-09 5:53 ` ganqixin
2020-11-09 9:01 ` Markus Armbruster
2020-11-30 13:26 ` Peter Maydell [this message]
2020-12-02 9:19 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA-JCLUn5BxwH71CmFB3Q+KMSK0pid8nGH9hLUokNcoLSw@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=ganqixin@huawei.com \
--cc=kuhn.chenqun@huawei.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).