From: Peter Maydell <peter.maydell@linaro.org>
To: John Snow <jsnow@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>,
qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 3/8] fdc: Introduce fdctrl->phase
Date: Tue, 19 May 2015 21:57:25 +0100 [thread overview]
Message-ID: <CAFEAcA-Jeu=BCtYnKuf5aUt48j5DBKtkUZh_YNpWxAzNhCzdDw@mail.gmail.com> (raw)
In-Reply-To: <555BA2A6.5090602@redhat.com>
On 19 May 2015 at 21:52, John Snow <jsnow@redhat.com> wrote:
> Hmm, I think this is not purely derived state because the flags are not
> necessarily sufficient for regenerating that state.
Yeah, if there's genuinely an underlying state machine that's
not completely visible in registers you need to actually model it.
You should probably then model the register bits by calculating
them from the state rather than by changing them as you go along
in parallel with moving the state machine around.
-- PMM
next prev parent reply other threads:[~2015-05-19 20:57 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-19 15:35 [Qemu-devel] [PATCH 0/8] fdc: Clean up and fix command processing Kevin Wolf
2015-05-19 15:35 ` [Qemu-devel] [PATCH 1/8] fdc: Rename fdctrl_reset_fifo() to fdctrl_to_command_phase() Kevin Wolf
2015-05-19 20:37 ` John Snow
2015-05-19 15:35 ` [Qemu-devel] [PATCH 2/8] fdc: Rename fdctrl_set_fifo() to fdctrl_to_result_phase() Kevin Wolf
2015-05-19 20:38 ` John Snow
2015-05-19 15:35 ` [Qemu-devel] [PATCH 3/8] fdc: Introduce fdctrl->phase Kevin Wolf
2015-05-19 20:38 ` John Snow
2015-05-19 20:44 ` Peter Maydell
2015-05-19 20:52 ` John Snow
2015-05-19 20:57 ` Peter Maydell [this message]
2015-05-20 7:54 ` Kevin Wolf
2015-05-20 8:06 ` Peter Maydell
2015-05-20 8:43 ` Kevin Wolf
2015-05-20 9:24 ` Peter Maydell
2015-05-20 11:55 ` John Snow
2015-05-20 12:07 ` Peter Maydell
2015-05-21 9:42 ` Kevin Wolf
2015-05-21 9:47 ` Dr. David Alan Gilbert
2015-05-21 10:11 ` Peter Maydell
2015-05-21 10:31 ` Kevin Wolf
2015-05-21 11:09 ` Markus Armbruster
2015-05-21 11:14 ` Peter Maydell
2015-05-21 11:37 ` Dr. David Alan Gilbert
2015-05-19 15:35 ` [Qemu-devel] [PATCH 4/8] fdc: Use phase in fdctrl_write_data() Kevin Wolf
2015-05-19 20:39 ` John Snow
2015-05-19 20:52 ` Peter Maydell
2015-05-19 15:35 ` [Qemu-devel] [PATCH 5/8] fdc: Code cleanup " Kevin Wolf
2015-05-19 20:40 ` John Snow
2015-05-20 8:18 ` Kevin Wolf
2015-05-19 15:36 ` [Qemu-devel] [PATCH 6/8] fdc: Disentangle phases in fdctrl_read_data() Kevin Wolf
2015-05-19 20:40 ` John Snow
2015-05-20 8:25 ` Kevin Wolf
2015-05-20 11:59 ` John Snow
2015-05-19 15:36 ` [Qemu-devel] [PATCH 7/8] fdc: Fix MSR.RQM flag Kevin Wolf
2015-05-19 20:40 ` John Snow
2015-05-20 8:14 ` Kevin Wolf
2015-05-20 11:58 ` John Snow
2015-05-19 15:36 ` [Qemu-devel] [PATCH 8/8] fdc-test: Test state for existing cases more thoroughly Kevin Wolf
2015-05-19 20:41 ` John Snow
2015-05-19 20:37 ` [Qemu-devel] [PATCH 0/8] fdc: Clean up and fix command processing John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA-Jeu=BCtYnKuf5aUt48j5DBKtkUZh_YNpWxAzNhCzdDw@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).