From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53708) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YuoaH-0000yi-3l for qemu-devel@nongnu.org; Tue, 19 May 2015 16:57:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YuoaA-0000pE-Qn for qemu-devel@nongnu.org; Tue, 19 May 2015 16:57:53 -0400 Received: from mail-ig0-f175.google.com ([209.85.213.175]:36610) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YuoaA-0000ok-NB for qemu-devel@nongnu.org; Tue, 19 May 2015 16:57:46 -0400 Received: by igbpi8 with SMTP id pi8so86467639igb.1 for ; Tue, 19 May 2015 13:57:46 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <555BA2A6.5090602@redhat.com> References: <1432049762-2184-1-git-send-email-kwolf@redhat.com> <1432049762-2184-4-git-send-email-kwolf@redhat.com> <555BA2A6.5090602@redhat.com> From: Peter Maydell Date: Tue, 19 May 2015 21:57:25 +0100 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH 3/8] fdc: Introduce fdctrl->phase List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow Cc: Kevin Wolf , QEMU Developers , qemu-block@nongnu.org On 19 May 2015 at 21:52, John Snow wrote: > Hmm, I think this is not purely derived state because the flags are not > necessarily sufficient for regenerating that state. Yeah, if there's genuinely an underlying state machine that's not completely visible in registers you need to actually model it. You should probably then model the register bits by calculating them from the state rather than by changing them as you go along in parallel with moving the state machine around. -- PMM