From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:49018)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1TlSyV-0008P6-R5
	for qemu-devel@nongnu.org; Wed, 19 Dec 2012 18:22:57 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1TlSyU-0007VZ-Lt
	for qemu-devel@nongnu.org; Wed, 19 Dec 2012 18:22:55 -0500
Received: from mail-la0-f47.google.com ([209.85.215.47]:52093)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1TlSyU-0007VU-Eo
	for qemu-devel@nongnu.org; Wed, 19 Dec 2012 18:22:54 -0500
Received: by mail-la0-f47.google.com with SMTP id u2so1941481lag.6
	for <qemu-devel@nongnu.org>; Wed, 19 Dec 2012 15:22:52 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <CAAu8pHsVaZrhp1=J_ADgr22h5Gpf3qg88sJrWtDC74owjqrSbQ@mail.gmail.com>
References: <1355910821-21302-1-git-send-email-fred.konrad@greensocs.com>
	<1355910821-21302-9-git-send-email-fred.konrad@greensocs.com>
	<CAAu8pHsVaZrhp1=J_ADgr22h5Gpf3qg88sJrWtDC74owjqrSbQ@mail.gmail.com>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Wed, 19 Dec 2012 23:22:32 +0000
Message-ID: <CAFEAcA-K+M9drQ+mudXE36P7uveRbMLeeARW7SUu95VKf_2f=Q@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [RFC PATCH V8 08/15] virtio-blk : Add the
	virtio-blk device.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: aliguori@us.ibm.com, e.voevodin@samsung.com, mark.burton@greensocs.com, agraf@suse.de, qemu-devel@nongnu.org, stefanha@redhat.com, cornelia.huck@de.ibm.com, afaerber@suse.de, fred.konrad@greensocs.com

On 19 December 2012 20:00, Blue Swirl <blauwirbel@gmail.com> wrote:
> On Wed, Dec 19, 2012 at 9:53 AM,  <fred.konrad@greensocs.com> wrote:
>> +#ifdef __linux__
>> +#define DEFINE_VIRTIO_BLK_PROPERTIES(_state, _field)                      \
>> +        DEFINE_BLOCK_PROPERTIES(_state, _field.conf),                     \
>> +        DEFINE_BLOCK_CHS_PROPERTIES(_state, _field.conf),                 \
>> +        DEFINE_PROP_STRING("serial", _state, _field.serial),              \
>> +        DEFINE_PROP_BIT("scsi", _state, _field.scsi, 0, true)
>> +#else
>> +#define DEFINE_VIRTIO_BLK_PROPERTIES(_state, _field)                      \
>> +        DEFINE_BLOCK_PROPERTIES(_state, _field.conf),                     \
>> +        DEFINE_BLOCK_CHS_PROPERTIES(_state, _field.conf),                 \
>> +        DEFINE_PROP_STRING("serial", _state, _field.serial)
>
> Does the different property set mean that it would not be possible to
> migrate VMs which use virtio from non-Linux host to Linux and vice
> versa?

Probably, but note that this is just reflecting an existing ifdef in
the non-refactored implementation.

(I looked at that existing ifdef and thought "smells dubious", but
presumably there is a reason.)

-- PMM