From: Peter Maydell <peter.maydell@linaro.org>
To: Pranith Kumar <bobby.prani@gmail.com>
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"Richard Henderson" <rth@twiddle.net>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 2/2] linux-user: fix tcg/mmap test
Date: Wed, 18 Jan 2017 16:21:34 +0000 [thread overview]
Message-ID: <CAFEAcA-KFb6SAdBpuMHZVHDKQdFM3cWJNRuB-oaY8gsRv0Th=g@mail.gmail.com> (raw)
In-Reply-To: <20170118150235.23850-2-bobby.prani@gmail.com>
On 18 January 2017 at 15:02, Pranith Kumar <bobby.prani@gmail.com> wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> tests/tcg/mmap test fails with values other than default target page
> size. When creating a map beyond EOF, extra anonymous pages are added up
> to the target page boundary. Currently, this operation is performed only
> when qemu_real_host_page_size < TARGET_PAGE_SIZE, but it should be
> performed if the configured page size (qemu -p) is larger than
> qemu_real_host_page_size too.
>
> (also fixes some style issues to please checkpatch)
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>
This got reviewed-by with caveats from two people when
it was last sent but you have neither included the R-by
tags nor addressed the minor tweaks they asked you to
address.
thanks
-- PMM
next prev parent reply other threads:[~2017-01-18 16:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-18 15:02 [Qemu-devel] [PATCH 1/2] linux-user: fix settime old value location Pranith Kumar
2017-01-18 15:02 ` [Qemu-devel] [PATCH 2/2] linux-user: fix tcg/mmap test Pranith Kumar
2017-01-18 16:21 ` Peter Maydell [this message]
2017-01-18 16:20 ` [Qemu-devel] [PATCH 1/2] linux-user: fix settime old value location Peter Maydell
2017-01-18 16:27 ` Pranith Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA-KFb6SAdBpuMHZVHDKQdFM3cWJNRuB-oaY8gsRv0Th=g@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=bobby.prani@gmail.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).