From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E02E3C433EF for ; Mon, 30 May 2022 12:44:18 +0000 (UTC) Received: from localhost ([::1]:49082 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nvekr-0008UK-Iz for qemu-devel@archiver.kernel.org; Mon, 30 May 2022 08:44:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34160) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nveix-0006tg-5u for qemu-devel@nongnu.org; Mon, 30 May 2022 08:42:20 -0400 Received: from mail-yw1-x1133.google.com ([2607:f8b0:4864:20::1133]:37931) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nveit-0001xR-Vd for qemu-devel@nongnu.org; Mon, 30 May 2022 08:42:18 -0400 Received: by mail-yw1-x1133.google.com with SMTP id 00721157ae682-2ff7b90e635so108670147b3.5 for ; Mon, 30 May 2022 05:42:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hFSZCRu3hejMfLKNwEnpdml9rAf5cwSmm0i+frA3vMs=; b=gPSU+/9wVkn31IE8kogAk+gYkIDIOSJB1gSlk7NR9XiU73ySqcv0WjyERaJtLn0nPM Cglfbb9etXF32nNsyeuqPB91zUb+UDURXc1vyi0HLn0Jz7bFla11BqBNvQuLW4H5ZCVL T8jI1JTiZaYNK759DArsuiVNOfHxTO3L31LW+WRl5WMlLVQlu1UmhT0qhSphyXCt0xzx 8oYGFiRPI1+fOsnxi7QUoY9Solh+deKnoy6Zfrqe33RkhBLdpXvPjhj+GMHIIMOMs4lF rFncmT4Bp8Z+0vhLd2cvVSxy5FNmf7AmN5F4DlYZyBDgSVekq+FiT1uKF9mui5pHzO/f HMhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hFSZCRu3hejMfLKNwEnpdml9rAf5cwSmm0i+frA3vMs=; b=EwN98Ozgx3EbCJD1/RuLzmcEf1kn2G9gTpuEyO2ARbVK/7WXcmsVehV5P/ZW8HpnMs nIcL8TXIxxULdC6xqy1eOn7FsC9LKIBYoe43ttTlFVdVRUXuxW1SNM5H7zL5oaGe8uF1 jIfutpP8BqNcK4jGXdspkIY1Zvhs8HkO+21eXNEWejWg1c4Rmkp8dg7Favk5L6lUBIzo 3BsFK2IkLhtjGTNJIYDMKfHUc7hOqV5/cm18Zcp7+zjsGqcyubeq/cZnSEFkkfhTIfSe AWve/1Ibd3vFk8VZt6WjkGf2eMJyGwldNDaSljdESg/qQPi9LdA9OilQeZXeP3wVu4RZ hkyw== X-Gm-Message-State: AOAM532SC3Sq2IC/ouMbm34WJ5ca2jbECYEKxdvucCyhv6pNSQeG06iZ yLew962vjftIEVtJDc9R1v5r75XAKHrc7JyTL1ye5A== X-Google-Smtp-Source: ABdhPJziucl+ehz8bumj0qGRtg9hlPYLE49rUR9Yzk8G2HBeQ2dbaUBvxe4+EpHNecjDA7oGH71XuqxmwvxIFfYz/d4= X-Received: by 2002:a0d:fc83:0:b0:2e5:b0f4:c125 with SMTP id m125-20020a0dfc83000000b002e5b0f4c125mr59186286ywf.347.1653914533542; Mon, 30 May 2022 05:42:13 -0700 (PDT) MIME-Version: 1.0 References: <20220523204742.740932-1-richard.henderson@linaro.org> <20220523204742.740932-3-richard.henderson@linaro.org> In-Reply-To: <20220523204742.740932-3-richard.henderson@linaro.org> From: Peter Maydell Date: Mon, 30 May 2022 13:42:02 +0100 Message-ID: Subject: Re: [PATCH 02/18] target/arm: Use arm_current_el for simple exceptions To: Richard Henderson Cc: qemu-devel@nongnu.org, qemu-arm@nongnu.org Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2607:f8b0:4864:20::1133; envelope-from=peter.maydell@linaro.org; helo=mail-yw1-x1133.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, 23 May 2022 at 21:49, Richard Henderson wrote: > > For these cases, the syndrome does not depend on the > origin or target EL, so we can simply defer selection > of the target EL to raise_exception. The commit message says "defer to raise_exception()", but that would mean passing 0 as the cur_or_target_el, which mostly these changes aren't doing. Instead it looks like what we're relying on is that if arm_current_el() != 0 then exception_target_el() == arm_current_el(), and if arm_current_el() is 0 then raise_exception() will call exception_target_el() for us. Which is true, but not really what the commit message is saying. -- PMM