From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:55221) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TLYN0-0004Ys-Ua for qemu-devel@nongnu.org; Tue, 09 Oct 2012 07:53:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TLYMz-00082e-Rq for qemu-devel@nongnu.org; Tue, 09 Oct 2012 07:53:06 -0400 Received: from mail-ie0-f173.google.com ([209.85.223.173]:53160) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TLYMz-00082Y-N1 for qemu-devel@nongnu.org; Tue, 09 Oct 2012 07:53:05 -0400 Received: by mail-ie0-f173.google.com with SMTP id 17so2420724iea.4 for ; Tue, 09 Oct 2012 04:53:05 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: Date: Tue, 9 Oct 2012 12:53:05 +0100 Message-ID: From: Peter Maydell Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH v2 3/4] zynq_slcr: Fixed ResetValues enum List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Crosthwaite Cc: linnj@xilinx.com, edgar.iglesias@gmail.com, qemu-devel@nongnu.org, john.williams@petalogix.com On 4 October 2012 01:16, Peter Crosthwaite wrote: > From: Peter A. G. Crosthwaite > > There is a gap in the reset region of the address space at offset 0x208. This > throws out all these enum values by one when translating them to address offsets. > Fixed by putting the corresponding gap in the enum as well. > > Signed-off-by: Peter A. G. Crosthwaite This fix isn't dependent on the rest of this patchset, right? I can put it in arm-devs.next now if you like or you could send it via -trivial. Reviewed-by: Peter Maydell -- PMM