From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37521)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1VvDoj-0007Xt-N4
	for qemu-devel@nongnu.org; Mon, 23 Dec 2013 17:17:46 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1VvDoe-0002bJ-RV
	for qemu-devel@nongnu.org; Mon, 23 Dec 2013 17:17:41 -0500
Received: from mail-pa0-f46.google.com ([209.85.220.46]:55793)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1VvDoe-0002bC-LE
	for qemu-devel@nongnu.org; Mon, 23 Dec 2013 17:17:36 -0500
Received: by mail-pa0-f46.google.com with SMTP id kp14so3925751pab.33
	for <qemu-devel@nongnu.org>; Mon, 23 Dec 2013 14:17:35 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <1387836029-17163-1-git-send-email-rjones@redhat.com>
References: <1387836029-17163-1-git-send-email-rjones@redhat.com>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Mon, 23 Dec 2013 22:17:15 +0000
Message-ID: <CAFEAcA-MGw+o7KV=6BQwFTkvw3-wCk5ObcgQY3JqYKTpm-C-iw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH] arm64: Set source for ret instruction
	correctly.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Richard W.M. Jones" <rjones@redhat.com>, Alexander Graf <agraf@suse.de>
Cc: Michael Matz <matz@suse.de>, QEMU Developers <qemu-devel@nongnu.org>

On 23 December 2013 22:00, Richard W.M. Jones <rjones@redhat.com> wrote:
> From: "Richard W.M. Jones" <rjones@redhat.com>
>
> Fixes https://bugs.launchpad.net/qemu/+bug/1263747
>
> Signed-off-by: Richard W.M. Jones <rjones@redhat.com>
> Tested-by: Richard W.M. Jones <rjones@redhat.com>
> ---

I'm guessing this is against the SuSE tree? Probably best to
say so specifically, because this code is different in mainline.
CC'ing Alex who might also care about SuSE tree fixes.


>  target-arm/translate-a64.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/target-arm/translate-a64.c b/target-arm/translate-a64.c
> index 36ebb0f..29454b0 100644
> --- a/target-arm/translate-a64.c
> +++ b/target-arm/translate-a64.c
> @@ -273,7 +273,6 @@ static void handle_br(DisasContext *s, uint32_t insn)
>          tcg_gen_movi_i64(cpu_reg(30), s->pc);
>          break;
>      case 2: /* RET */
> -        source = 30;
>          break;
>      case 3:
>          unallocated_encoding(s);
> --
> 1.8.3.1
>

FWIW mainline's handling of this insn doesn't have this bug.

thanks
-- PMM