From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:55900) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SzC1n-0003yT-P7 for qemu-devel@nongnu.org; Wed, 08 Aug 2012 15:34:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SzC1m-0005E3-P5 for qemu-devel@nongnu.org; Wed, 08 Aug 2012 15:34:47 -0400 Received: from mail-gh0-f173.google.com ([209.85.160.173]:40496) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SzC1m-0005Dw-LC for qemu-devel@nongnu.org; Wed, 08 Aug 2012 15:34:46 -0400 Received: by ghrr17 with SMTP id r17so1152967ghr.4 for ; Wed, 08 Aug 2012 12:34:46 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <1344351173-2716-1-git-send-email-cornelia.huck@de.ibm.com> <1344351173-2716-3-git-send-email-cornelia.huck@de.ibm.com> <20120808101750.35800579@BR9GNB5Z> Date: Wed, 8 Aug 2012 20:34:45 +0100 Message-ID: From: Peter Maydell Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH 2/5] s390: Virtual channel subsystem support. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: linux-s390 , Anthony Liguori , Rusty Russell , KVM , Carsten Otte , Sebastian Ott , Marcelo Tosatti , Heiko Carstens , qemu-devel , Alexander Graf , Christian Borntraeger , Avi Kivity , Cornelia Huck , Martin Schwidefsky On 8 August 2012 20:16, Blue Swirl wrote: > On Wed, Aug 8, 2012 at 8:17 AM, Cornelia Huck wrote: >> On Tue, 7 Aug 2012 21:00:59 +0000 >> Blue Swirl wrote: >>> Please use more descriptive names instead of acronyms, for example SubChStatus. >> >> I'd rather leave these at the well-known scsw, pmcw, etc. names. These >> have been around for decades, and somebody familiar with channel I/O >> will instantly know what a struct scsw is, but will need to look hard >> at the code to figure out the meaning of SubChStatus. > > If they are well-known and have been around for so long time, are > there any suitable header files (with compatible licenses) where they > are defined which could be reused? > > Otherwise, please follow CODING_STYLE. I think we should follow CODING_STYLE for capitalisation issues but generally if the device's documentation has standard abbreviations for register names, structures, etc, etc we should use them. Often this code has to be maintained later by somebody else who might not be familiar with the general operation of the hardware and who is trying to match up the code with whatever the data sheet says. Following the naming used in the h/w docs makes that job easier. (for instance I took the opportunity of making a bunch of structure member names in target-arm line up with the ARM ARM names as part of the refactoring that went on a while back.) -- PMM