Re: [PATCH v4 00/47] AMD Versal Gen 2 support

[Peter Maydell <peter.maydell@linaro.org>]

On Thu, 11 Sept 2025 at 08:08, Luc Michel <luc.michel@amd.com> wrote:
>
> Gentle ping. Only patches 23 and 39 need review.

ASAN complains about a couple of new leaks; would you mind
taking a look?

Direct leak of 80 byte(s) in 2 object(s) allocated from:
    #0 0x5df4de8f7e23 in malloc
(/mnt/nvmedisk/linaro/qemu-from-laptop/qemu/build/arm-asan/qemu-system-aarch64+0x2507e23)
(BuildId: 2cb010a0f1032af1fc9fe4c70583ed9f639b86fb)
    #1 0x77eec4c4cb09 in g_malloc
(/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x62b09) (BuildId:
1eb6131419edb83b2178b682829a6913cf682d75)
    #2 0x77eec4c0fbc2 in g_array_sized_new
(/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x25bc2) (BuildId:
1eb6131419edb83b2178b682829a6913cf682d75)
    #3 0x5df4e0b46004 in versal_base_init
/mnt/nvmedisk/linaro/qemu-from-laptop/qemu/build/arm-asan/../../hw/arm/xlnx-versal.c:2081:15


Direct leak of 48 byte(s) in 2 object(s) allocated from:
    #0 0x5df4de8f800d in calloc
(/mnt/nvmedisk/linaro/qemu-from-laptop/qemu/build/arm-asan/qemu-system-aarch64+0x250800d)
(BuildId: 2cb010a0f1032af1fc9fe4c70583ed9f639b86fb)
    #1 0x77eec4c4d7b1 in g_malloc0
(/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x637b1) (BuildId:
1eb6131419edb83b2178b682829a6913cf682d75)
    #2 0x5df4e0b4615a in versal_base_init
/mnt/nvmedisk/linaro/qemu-from-laptop/qemu/build/arm-asan/../../hw/arm/xlnx-versal.c:2084:21

This is from a run of 'make check' for arm targets with clang's
ASAN. I use the following leak suppression file to skip various
leaks we already know about:

# This is a set of suppressions for LeakSanitizer; you can use it
# by setting
#   LSAN_OPTIONS="suppressions=/path/to/scripts/lsan-suppressions.txt"
# when running a QEMU built with the leak-sanitizer.

# This is a real leak but ignore it for now so we can see the others
leak:memory_region_init
# various leaks I think are due to memory region circular refs
# annoyingly you can't match on filename:lineno
leak:fsl_imx6_init
leak:fsl_imx7_init
leak:raspi_peripherals_base_init
leak:fsl_imx25_init
leak:fsl_imx6ul_init
leak:aw_a10_init
leak:allwinner_r40_init
leak:usb_dwc3_init
leak:xlnx_zynqmp_init
leak:xhci_sysbus_instance_init
leak:fsl_imx8mp_init
leak:versal_usb2_init


# register_init_block API is busted
leak:register_init_block
# so is this device's local hack variant of it
leak:canfd_create_regarray
# qtest-only leak, not very important
leak:qemu_irq_intercept_in
# this is maybe a leak caused by g_test_trap_subprocess():
# in the subprocess, the cleanup functions that are supposed to free
# memory don't get run for some reason.
leak:qos_traverse_graph

thanks
-- PMM