* [PATCH v2] xlnx-versal-ospi: disable reentrancy detection for iomem_dac
@ 2024-02-19 10:56 Sai Pavan Boddu
2024-02-22 14:06 ` Peter Maydell
0 siblings, 1 reply; 2+ messages in thread
From: Sai Pavan Boddu @ 2024-02-19 10:56 UTC (permalink / raw)
To: qemu-devel, qemu-arm, qemu-block
Cc: Peter Maydell, Alistair Francis, Edgar E . Iglesias, Kevin Wolf,
Francisco Iglesias, sai.pavan.boddu
The OSPI DMA reads flash data through the OSPI linear address space (the
iomem_dac region), because of this the reentrancy guard introduced in
commit a2e1753b ("memory: prevent dma-reentracy issues") is disabled for
the memory region.
Signed-off-by: Sai Pavan Boddu <sai.pavan.boddu@amd.com>
---
Changes for V2:
Added code comments.
hw/ssi/xlnx-versal-ospi.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/hw/ssi/xlnx-versal-ospi.c b/hw/ssi/xlnx-versal-ospi.c
index c7b95b1f37..c479138ec1 100644
--- a/hw/ssi/xlnx-versal-ospi.c
+++ b/hw/ssi/xlnx-versal-ospi.c
@@ -1772,6 +1772,12 @@ static void xlnx_versal_ospi_init(Object *obj)
memory_region_init_io(&s->iomem_dac, obj, &ospi_dac_ops, s,
TYPE_XILINX_VERSAL_OSPI "-dac", 0x20000000);
sysbus_init_mmio(sbd, &s->iomem_dac);
+ /*
+ * The OSPI DMA reads flash data through the OSPI linear address space (the
+ * iomem_dac region), because of this the reentrancy guard needs to be
+ * disabled.
+ */
+ s->iomem_dac.disable_reentrancy_guard = true;
sysbus_init_irq(sbd, &s->irq);
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v2] xlnx-versal-ospi: disable reentrancy detection for iomem_dac
2024-02-19 10:56 [PATCH v2] xlnx-versal-ospi: disable reentrancy detection for iomem_dac Sai Pavan Boddu
@ 2024-02-22 14:06 ` Peter Maydell
0 siblings, 0 replies; 2+ messages in thread
From: Peter Maydell @ 2024-02-22 14:06 UTC (permalink / raw)
To: Sai Pavan Boddu
Cc: qemu-devel, qemu-arm, qemu-block, Alistair Francis,
Edgar E . Iglesias, Kevin Wolf, Francisco Iglesias
On Mon, 19 Feb 2024 at 10:56, Sai Pavan Boddu <sai.pavan.boddu@amd.com> wrote:
>
> The OSPI DMA reads flash data through the OSPI linear address space (the
> iomem_dac region), because of this the reentrancy guard introduced in
> commit a2e1753b ("memory: prevent dma-reentracy issues") is disabled for
> the memory region.
>
> Signed-off-by: Sai Pavan Boddu <sai.pavan.boddu@amd.com>
> ---
> Changes for V2:
> Added code comments.
>
> hw/ssi/xlnx-versal-ospi.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/hw/ssi/xlnx-versal-ospi.c b/hw/ssi/xlnx-versal-ospi.c
> index c7b95b1f37..c479138ec1 100644
> --- a/hw/ssi/xlnx-versal-ospi.c
> +++ b/hw/ssi/xlnx-versal-ospi.c
> @@ -1772,6 +1772,12 @@ static void xlnx_versal_ospi_init(Object *obj)
> memory_region_init_io(&s->iomem_dac, obj, &ospi_dac_ops, s,
> TYPE_XILINX_VERSAL_OSPI "-dac", 0x20000000);
> sysbus_init_mmio(sbd, &s->iomem_dac);
> + /*
> + * The OSPI DMA reads flash data through the OSPI linear address space (the
> + * iomem_dac region), because of this the reentrancy guard needs to be
> + * disabled.
> + */
> + s->iomem_dac.disable_reentrancy_guard = true;
Applied to target-arm.next, thanks.
-- PMM
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-02-22 14:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-19 10:56 [PATCH v2] xlnx-versal-ospi: disable reentrancy detection for iomem_dac Sai Pavan Boddu
2024-02-22 14:06 ` Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).