From: Peter Maydell <peter.maydell@linaro.org>
To: Gan Qixin <ganqixin@huawei.com>
Cc: "Laurent Vivier" <lvivier@redhat.com>,
zhanghailiang <zhang.zhanghailiang@huawei.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"QEMU Trivial" <qemu-trivial@nongnu.org>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"Alistair Francis" <alistair.francis@wdc.com>,
"Chenqun (kuhn)" <kuhn.chenqun@huawei.com>,
"David Gibson" <david@gibson.dropbear.id.au>
Subject: Re: [PATCH 00/10] Fix line over 80 characters warning
Date: Tue, 20 Oct 2020 12:14:51 +0100 [thread overview]
Message-ID: <CAFEAcA-NPcXxh7QPtUtY5CornQjb-vTb_kCzRUSwMCZqkVVkBg@mail.gmail.com> (raw)
In-Reply-To: <20201019203023.658555-1-ganqixin@huawei.com>
On Tue, 20 Oct 2020 at 12:03, Gan Qixin <ganqixin@huawei.com> wrote:
>
> Hi all,
> I used scripts/checkpatch.pl to find that many files in the hw directory
> contain lines with more than 80 characters. Therefore, I splited some lines to
> fix this warning.
I personally have come round to the idea that we should instead
adjust checkpatch so that it doesn't have a hard 80 character
complaint limit.
Compare the kernel coding style change:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=bdc48fa11e46f867ea4d75fa59ee87a7f48be144
whose rationale I agree with. We should *prefer* 80 character
wrapping, but there are some places where an 85-character
line is much more readable and sensible style than inserting
a line break just to please checkpatch.
thanks
-- PMM
next prev parent reply other threads:[~2020-10-20 11:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-19 20:30 [PATCH 00/10] Fix line over 80 characters warning Gan Qixin
2020-10-19 20:30 ` [PATCH 01/10] hw/virtio/:split some lines containing more than 80 characters Gan Qixin
2020-10-19 20:30 ` [PATCH 02/10] hw/core/:split " Gan Qixin
2020-10-19 20:30 ` [PATCH 03/10] hw/ide/:split " Gan Qixin
2020-10-19 20:30 ` [PATCH 04/10] hw/intc/:split " Gan Qixin
2020-10-19 20:30 ` [PATCH 05/10] hw/misc/:split " Gan Qixin
2020-10-19 20:30 ` [PATCH 06/10] hw/pci/:split " Gan Qixin
2020-10-19 20:30 ` [PATCH 07/10] hw/pci-host/:split " Gan Qixin
2020-10-19 20:30 ` [PATCH 08/10] hw/char/:split " Gan Qixin
2020-10-19 20:30 ` [PATCH 09/10] hw/input/:split " Gan Qixin
2020-10-19 20:30 ` [PATCH 10/10] hw/riscv/:split " Gan Qixin
2020-10-20 11:13 ` [PATCH 00/10] Fix line over 80 characters warning Daniel P. Berrangé
2020-10-20 12:24 ` ganqixin
2020-10-20 11:14 ` Peter Maydell [this message]
2020-10-20 12:24 ` ganqixin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA-NPcXxh7QPtUtY5CornQjb-vTb_kCzRUSwMCZqkVVkBg@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=alistair.francis@wdc.com \
--cc=david@gibson.dropbear.id.au \
--cc=f4bug@amsat.org \
--cc=ganqixin@huawei.com \
--cc=kuhn.chenqun@huawei.com \
--cc=lvivier@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).