From: Peter Maydell <peter.maydell@linaro.org>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: Jan Kiszka <jan.kiszka@web.de>, qemu-arm <qemu-arm@nongnu.org>,
QEMU Developers <qemu-devel@nongnu.org>,
Alistair Francis <alistair@alistair23.me>
Subject: Re: [PATCH-for-5.2 0/5] hw/arm: Fix various incorrect IRQ handling
Date: Mon, 9 Nov 2020 14:23:07 +0000 [thread overview]
Message-ID: <CAFEAcA-O7vrAAaMpMWyeUzAO3BOQf3A28XoSY72SB7zOgeedkw@mail.gmail.com> (raw)
In-Reply-To: <20201107193403.436146-1-f4bug@amsat.org>
On Sat, 7 Nov 2020 at 19:34, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> This series is inspired by Peter's following patch:
> https://www.mail-archive.com/qemu-devel@nongnu.org/msg758178.html
>
> I started to audit the IRQ uses and fixed the easy problems.
>
> Unresolved ones:
> - stellaris_init() connects different TYPE_STELLARIS_GPTM
> to the same ADC input (seems some weird kludge)
> - platform_bus_link_device() uses sysbus_has_irq() to check
> if an device has IRQ mapped but it doesn't seem to work.
Were you finding these by inspection, or did you add some
kind of assert or other check for double-irq-line-connections?
Applied to target-arm.next, thanks (deletion of omap_uart_attach()
can be a separate followup cleanup).
-- PMM
next prev parent reply other threads:[~2020-11-09 14:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-07 19:33 [PATCH-for-5.2 0/5] hw/arm: Fix various incorrect IRQ handling Philippe Mathieu-Daudé
2020-11-07 19:33 ` [PATCH-for-5.2 1/5] hw/arm/armsse: Correct expansion MPC interrupt lines Philippe Mathieu-Daudé
2020-11-07 19:34 ` [PATCH-for-5.2 2/5] hw/misc/stm32f2xx_syscfg: Remove extraneous IRQ Philippe Mathieu-Daudé
2020-11-07 19:34 ` [PATCH-for-5.2 3/5] hw/arm/nseries: Remove invalid/unnecessary n8x0_uart_setup() Philippe Mathieu-Daudé
2020-11-09 14:22 ` Peter Maydell
2020-11-07 19:34 ` [PATCH-for-5.2? 4/5] hw/arm/musicpal: Don't connect two qemu_irqs directly to the same input Philippe Mathieu-Daudé
2020-11-07 19:34 ` [PATCH-for-6.0 5/5] hw/arm/musicpal: Only use qdev_get_gpio_in() when necessary Philippe Mathieu-Daudé
2020-11-09 14:23 ` Peter Maydell [this message]
2020-11-09 14:45 ` [PATCH-for-5.2 0/5] hw/arm: Fix various incorrect IRQ handling Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA-O7vrAAaMpMWyeUzAO3BOQf3A28XoSY72SB7zOgeedkw@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=alistair@alistair23.me \
--cc=f4bug@amsat.org \
--cc=jan.kiszka@web.de \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).