From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60169)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1bT8Jw-0002O2-8I
	for qemu-devel@nongnu.org; Fri, 29 Jul 2016 09:59:25 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1bT8Ju-0007PT-En
	for qemu-devel@nongnu.org; Fri, 29 Jul 2016 09:59:23 -0400
Received: from mail-ua0-x22e.google.com ([2607:f8b0:400c:c08::22e]:35967)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1bT8Ju-0007P9-0S
	for qemu-devel@nongnu.org; Fri, 29 Jul 2016 09:59:22 -0400
Received: by mail-ua0-x22e.google.com with SMTP id j59so62335030uaj.3
	for <qemu-devel@nongnu.org>; Fri, 29 Jul 2016 06:59:21 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <1465835259-21449-1-git-send-email-fred.konrad@greensocs.com>
References: <1465835259-21449-1-git-send-email-fred.konrad@greensocs.com>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Fri, 29 Jul 2016 14:59:02 +0100
Message-ID: <CAFEAcA-OMptUEKAGhpiH4-r0omcrGaK0tRc687UGjvd2GPFL7g@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [RFC PATCH 00/11] Clock framework API.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?S09OUkFEIEZyw6lkw6lyaWM=?= <fred.konrad@greensocs.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>, Edgar Iglesias <edgar.iglesias@xilinx.com>, Alistair Francis <alistair.francis@xilinx.com>, Mark Burton <mark.burton@greensocs.com>

On 13 June 2016 at 17:27,  <fred.konrad@greensocs.com> wrote:
> From: KONRAD Frederic <fred.konrad@greensocs.com>
>
> Hi,
>
> This is a first draft of the clock framework API it contains:
>
>   * The first 5 patches which introduce the framework.
>   * The 6th patch which introduces a fixed-clock model.
>   * The rest which gives an example how to model a PLL from the existing
>     zynqmp-crf extracted from the qemu xilinx tree.
>
> No specific behavior is expected yet when the CRF register set is accessed but
> the user can see for example the dp_video_ref and vpll_to_lpd rate changing in
> the monitor with the "info qtree" command when the vpll_ctrl register is
> modified.

Apologies for the 6-week-late review. I think mostly this is
along the right lines but I've given comments where I have
specific issues.

It might also be useful to sketch out how a simple clock
tree would look in the documentation file.

thanks
-- PMM