From: Peter Maydell <peter.maydell@linaro.org>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: "QEMU Developers" <qemu-devel@nongnu.org>,
"KONRAD Frédéric" <fred.konrad@greensocs.com>
Subject: Re: [Qemu-devel] [PATCH] aux: fix break that wanted to break two levels out
Date: Mon, 4 Jul 2016 18:29:58 +0100 [thread overview]
Message-ID: <CAFEAcA-OOoZK0fBYHDFdRs_kyNj5OySXgnK4-y8i6KTixXOEeQ@mail.gmail.com> (raw)
In-Reply-To: <1466514977-12670-2-git-send-email-pbonzini@redhat.com>
On 21 June 2016 at 14:16, Paolo Bonzini <pbonzini@redhat.com> wrote:
> The last "ret = AUX_I2C_NACK;" is dead, because it is always overridden
> by AUX_I2C_ACK. What really the code wants is to jump out of the switch
> statement, and a "return" will not cut it because it would omit a debug
> printf.
>
> Change the logic so that we can break out of the while loop. For clarity,
> hoist the bus->last_* assignments up, right after i2c_start_transfer.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> hw/misc/aux.c | 12 ++++++------
Applied to target-arm.next, thanks.
-- PMM
next prev parent reply other threads:[~2016-07-04 17:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-21 13:16 [Qemu-devel] [PATCH] xlnx_dp: fix iffy xlnx_dp_aux_push_tx_fifo Paolo Bonzini
2016-06-21 13:16 ` [Qemu-devel] [PATCH] aux: fix break that wanted to break two levels out Paolo Bonzini
2016-07-04 17:29 ` Peter Maydell [this message]
2016-06-21 14:09 ` [Qemu-devel] [PATCH] xlnx_dp: fix iffy xlnx_dp_aux_push_tx_fifo KONRAD Frederic
2016-06-21 22:14 ` Eric Blake
2016-06-22 7:28 ` KONRAD Frederic
2016-07-04 17:30 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA-OOoZK0fBYHDFdRs_kyNj5OySXgnK4-y8i6KTixXOEeQ@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=fred.konrad@greensocs.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).