From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:35830) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXAvw-0001Wm-K6 for qemu-devel@nongnu.org; Wed, 23 May 2012 08:44:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SXAvp-0003zl-HS for qemu-devel@nongnu.org; Wed, 23 May 2012 08:44:56 -0400 Received: from mail-gg0-f173.google.com ([209.85.161.173]:57078) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXAvp-0003zD-Dl for qemu-devel@nongnu.org; Wed, 23 May 2012 08:44:49 -0400 Received: by ggnp1 with SMTP id p1so7939716ggn.4 for ; Wed, 23 May 2012 05:44:46 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1337504561-20297-1-git-send-email-gleb@redhat.com> References: <1337504561-20297-1-git-send-email-gleb@redhat.com> Date: Wed, 23 May 2012 13:44:45 +0100 Message-ID: From: Peter Maydell Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH 1/2] Make pointer to fw_cfg device global. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gleb Natapov Cc: qemu-devel@nongnu.org On 20 May 2012 10:02, Gleb Natapov wrote: > There can be only one fw_cfg device, so saving global reference to it > removes the need to pass its pointer around. This seems like a backwards step to me: one of the things that prevents us supporting "two separate machines in one emulation" is that we have various things that assume there's only one instance of themselves and use globals. I don't think we should be adding any more... -- PMM