qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: peter.chubb@nicta.com.au
Cc: qemu-devel@nongnu.org, philipo@ok-labs.com
Subject: Re: [Qemu-devel] [patch V4 4/4] FreeSCALE i.MX31 support: KZM-ARM11-01 evaluation board
Date: Thu, 15 Mar 2012 17:20:16 +0000	[thread overview]
Message-ID: <CAFEAcA-QGO+Q7bjuQK2OMsjq_WikAW0hN+99OjeexLHz3ws70A@mail.gmail.com> (raw)
In-Reply-To: <20120309033035.021670210@nicta.com.au>

On 9 March 2012 03:27,  <peter.chubb@nicta.com.au> wrote:
> Board support for Kyoto Micro's KZM-ARM11-01, an evaluation board built
> around the FreeScale i.MX31.
>
>
> Signed-off-by: Philip O'Sullivan <philipo@ok-labs.com>
> Signed-off-by: Peter Chubb <peter.chubb@nicta.com.au>
> ---
>  Makefile.target |    1
>  hw/kzm.c        |  159 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 160 insertions(+)
>  create mode 100644 hw/kzm.c
>
> Index: qemu-working/hw/kzm.c
> ===================================================================
> --- /dev/null   1970-01-01 00:00:00.000000000 +0000
> +++ qemu-working/hw/kzm.c       2012-03-09 14:13:54.578127780 +1100
> @@ -0,0 +1,159 @@
> +/*
> + * KZM Board System emulation.
> + *
> + * Copyright (c) 2008 OKL and 2011 NICTA
> + * Written by Hans
> + * Updated by Peter Chubb.
> + *
> + * This code is licenced under the GPL, version 2 or later.
> + * See the file `COPYING' in the top level directory.
> + *
> + * It (partially) emulates a Kyoto Microcomputer
> + * KZM-ARM11-01 evaluation board, with a FreeScale
> + * I.MX31 SoC
> + */
> +
> +#include "sysbus.h"
> +#include "exec-memory.h"
> +#include "hw.h"
> +#include "arm-misc.h"
> +#include "primecell.h"

You don't need this include.

> +#include "devices.h"
> +#include "pci.h"

Nor this one, I suspect.

> +#include "net.h"
> +#include "sysemu.h"
> +#include "boards.h"
> +#include "pc.h" /* for the FPGA UART that emulates a 16550 */
> +#include "imx.h"
> +
> +    /* Memory map for Kzm Emulation Baseboard:
> +     * 0x00000000-0x00003fff 16k secure ROM       IGNORED
> +     * 0x00004000-0x00407fff Reserved             IGNORED
> +     * 0x00404000-0x00407fff ROM                  IGNORED
> +     * 0x00408000-0x0fffffff Reserved             IGNORED
> +     * 0x10000000-0x1fffBfff RAM aliasing         IGNORED

that capital 'B' in the hex addr should be lowercased...

Otherwise looks OK. If the only changes to this patch in the next
round are removing unneeded #include lines and lowercasing that 'B'
you can add my 'Reviewed-by: Peter Maydell <peter.maydell@linaro.org>'
tag when you post the next version.

-- PMM

      reply	other threads:[~2012-03-15 17:20 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-09  3:27 [Qemu-devel] [patch V4 0/4] Support for i.MX31 and the Kyoto KZM11 board peter.chubb
2012-03-09  3:27 ` [Qemu-devel] [patch V4 1/4] i.MX UART support peter.chubb
2012-03-15 17:01   ` Peter Maydell
2012-03-15 21:10     ` Peter Chubb
2012-03-15 21:15       ` Peter Maydell
2012-03-09  3:27 ` [Qemu-devel] [patch V4 2/4] FreeSCALE i.MX31 support: Timers peter.chubb
2012-03-15 17:08   ` Peter Maydell
2012-03-15 17:08     ` Peter Maydell
2012-03-15 21:02       ` Peter Chubb
2012-03-09  3:27 ` [Qemu-devel] [patch V4 3/4] FreeSCALE i.MX31 support: AVIC peter.chubb
2012-03-15 17:14   ` Peter Maydell
2012-03-09  3:27 ` [Qemu-devel] [patch V4 4/4] FreeSCALE i.MX31 support: KZM-ARM11-01 evaluation board peter.chubb
2012-03-15 17:20   ` Peter Maydell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFEAcA-QGO+Q7bjuQK2OMsjq_WikAW0hN+99OjeexLHz3ws70A@mail.gmail.com \
    --to=peter.maydell@linaro.org \
    --cc=peter.chubb@nicta.com.au \
    --cc=philipo@ok-labs.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).