From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:48046) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S8ELp-0007Ea-Cu for qemu-devel@nongnu.org; Thu, 15 Mar 2012 13:20:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S8ELb-0008Ff-Bd for qemu-devel@nongnu.org; Thu, 15 Mar 2012 13:20:32 -0400 Received: from mail-ey0-f173.google.com ([209.85.215.173]:35041) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S8ELb-0008FN-5O for qemu-devel@nongnu.org; Thu, 15 Mar 2012 13:20:19 -0400 Received: by eaaf11 with SMTP id f11so1988751eaa.4 for ; Thu, 15 Mar 2012 10:20:16 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20120309033035.021670210@nicta.com.au> References: <20120309032737.637764791@nicta.com.au> <20120309033035.021670210@nicta.com.au> Date: Thu, 15 Mar 2012 17:20:16 +0000 Message-ID: From: Peter Maydell Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [patch V4 4/4] FreeSCALE i.MX31 support: KZM-ARM11-01 evaluation board List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: peter.chubb@nicta.com.au Cc: qemu-devel@nongnu.org, philipo@ok-labs.com On 9 March 2012 03:27, wrote: > Board support for Kyoto Micro's KZM-ARM11-01, an evaluation board built > around the FreeScale i.MX31. > > > Signed-off-by: Philip O'Sullivan > Signed-off-by: Peter Chubb > --- > =C2=A0Makefile.target | =C2=A0 =C2=A01 > =C2=A0hw/kzm.c =C2=A0 =C2=A0 =C2=A0 =C2=A0| =C2=A0159 +++++++++++++++++++= +++++++++++++++++++++++++++++++++++++ > =C2=A02 files changed, 160 insertions(+) > =C2=A0create mode 100644 hw/kzm.c > > Index: qemu-working/hw/kzm.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- /dev/null =C2=A0 1970-01-01 00:00:00.000000000 +0000 > +++ qemu-working/hw/kzm.c =C2=A0 =C2=A0 =C2=A0 2012-03-09 14:13:54.578127= 780 +1100 > @@ -0,0 +1,159 @@ > +/* > + * KZM Board System emulation. > + * > + * Copyright (c) 2008 OKL and 2011 NICTA > + * Written by Hans > + * Updated by Peter Chubb. > + * > + * This code is licenced under the GPL, version 2 or later. > + * See the file `COPYING' in the top level directory. > + * > + * It (partially) emulates a Kyoto Microcomputer > + * KZM-ARM11-01 evaluation board, with a FreeScale > + * I.MX31 SoC > + */ > + > +#include "sysbus.h" > +#include "exec-memory.h" > +#include "hw.h" > +#include "arm-misc.h" > +#include "primecell.h" You don't need this include. > +#include "devices.h" > +#include "pci.h" Nor this one, I suspect. > +#include "net.h" > +#include "sysemu.h" > +#include "boards.h" > +#include "pc.h" /* for the FPGA UART that emulates a 16550 */ > +#include "imx.h" > + > + =C2=A0 =C2=A0/* Memory map for Kzm Emulation Baseboard: > + =C2=A0 =C2=A0 * 0x00000000-0x00003fff 16k secure ROM =C2=A0 =C2=A0 =C2= =A0 IGNORED > + =C2=A0 =C2=A0 * 0x00004000-0x00407fff Reserved =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 IGNORED > + =C2=A0 =C2=A0 * 0x00404000-0x00407fff ROM =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0IGNORED > + =C2=A0 =C2=A0 * 0x00408000-0x0fffffff Reserved =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 IGNORED > + =C2=A0 =C2=A0 * 0x10000000-0x1fffBfff RAM aliasing =C2=A0 =C2=A0 =C2=A0= =C2=A0 IGNORED that capital 'B' in the hex addr should be lowercased... Otherwise looks OK. If the only changes to this patch in the next round are removing unneeded #include lines and lowercasing that 'B' you can add my 'Reviewed-by: Peter Maydell ' tag when you post the next version. -- PMM