qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: Liviu Ionescu <ilg@livius.net>
Cc: Christopher Covington <christopher.covington@linaro.org>,
	Leon Alrae <leon.alrae@imgtec.com>,
	QEMU Developers <qemu-devel@nongnu.org>,
	Matthew Fortune <matthew.fortune@imgtec.com>
Subject: Re: [Qemu-devel] [PATCH v3 2/2] semihosting: add --semihosting-config arg sub-argument
Date: Thu, 21 May 2015 16:29:52 +0100	[thread overview]
Message-ID: <CAFEAcA-QqmLFL7gEGC47pExky5JSZOKBELHehyrpcB2A1f0Ffw@mail.gmail.com> (raw)
In-Reply-To: <078E10E9-9879-4EB6-8D09-AADB88EAACAB@livius.net>

On 21 May 2015 at 16:24, Liviu Ionescu <ilg@livius.net> wrote:
>
>> On 21 May 2015, at 18:06, Peter Maydell <peter.maydell@linaro.org> wrote:
>>
>> ...
>> That's their choice... It is still an array of substrings,
>> but if the user only provides one string then we have an
>> array of length 1.
>
> this was my initial point, as long as you offer the choice,
> you no longer have consistent usage between ARM and MIPS,
> the ARM users will prefer the array of length 1.

There's no way to not offer the choice. In your syntax
this would be
 --semihosting-cmdline "foo bar baz"

>> ...
>> Adding quotes and apostrophes seems wrong to me,
>> because it's making assumptions about the guest's
>> handling of the semihosting string.
>
> yes, it is making the assumption that the guest code is able to
> process args with embedded spaces. once this accepted, properly
> parsing the quotes and apostrophes is required anyway

Required by who? It's not in the semihosting API. You
could perfectly well have a guest which required arguments
with spaces to be quoted via <> characters, or which
just treated the whole string as a single element, or
which didn't have any quoting support...

-- PMM

  reply	other threads:[~2015-05-21 15:30 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-08 11:41 [Qemu-devel] [PATCH v3 0/2] semihosting: clean up and add --semihosting-config arg Leon Alrae
2015-05-08 11:41 ` [Qemu-devel] [PATCH v3 1/2] semihosting: create SemihostingConfig structure and semihost.h Leon Alrae
2015-05-08 11:41 ` [Qemu-devel] [PATCH v3 2/2] semihosting: add --semihosting-config arg sub-argument Leon Alrae
2015-05-18 16:18   ` Peter Maydell
2015-05-20  8:11     ` Leon Alrae
2015-05-20  8:30       ` Liviu Ionescu
2015-05-20  8:51         ` Leon Alrae
2015-05-20 11:12           ` Liviu Ionescu
2015-05-20 13:10             ` Leon Alrae
2015-05-20  8:54       ` Peter Maydell
2015-05-20  9:31         ` Leon Alrae
2015-05-20 13:49           ` Liviu Ionescu
2015-05-20 14:18             ` Peter Maydell
2015-05-20 14:31               ` Liviu Ionescu
2015-05-20 14:40                 ` Peter Maydell
2015-05-20 14:59                   ` Liviu Ionescu
2015-05-20 15:11                     ` Peter Maydell
2015-05-20 15:47                       ` Liviu Ionescu
2015-05-21 13:57         ` Leon Alrae
2015-05-21 14:01           ` Peter Maydell
2015-05-21 14:26             ` Leon Alrae
2015-05-21 14:28           ` Liviu Ionescu
2015-05-21 14:33             ` Peter Maydell
2015-05-21 14:57               ` Liviu Ionescu
2015-05-21 15:06                 ` Peter Maydell
2015-05-21 15:24                   ` Liviu Ionescu
2015-05-21 15:29                     ` Peter Maydell [this message]
2015-05-21 15:47                       ` Liviu Ionescu
2015-05-21 15:54                         ` Peter Maydell
2015-05-21 16:36                           ` Liviu Ionescu
2015-05-21 16:56                             ` Peter Maydell
2015-05-21 17:11                               ` Liviu Ionescu
2015-05-21 18:35             ` Maciej W. Rozycki
2015-05-21 18:58               ` Liviu Ionescu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFEAcA-QqmLFL7gEGC47pExky5JSZOKBELHehyrpcB2A1f0Ffw@mail.gmail.com \
    --to=peter.maydell@linaro.org \
    --cc=christopher.covington@linaro.org \
    --cc=ilg@livius.net \
    --cc=leon.alrae@imgtec.com \
    --cc=matthew.fortune@imgtec.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).