qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: Alistair Francis <alistair23@gmail.com>
Cc: Alistair Francis <alistair.francis@xilinx.com>,
	"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v1 1/1] target/arm: Fix the A53 L2CTLR typo
Date: Fri, 2 Mar 2018 10:35:55 +0000	[thread overview]
Message-ID: <CAFEAcA-RUbtzQSSvyqbG=-PD3kbui1=OdTiY2=rjWtrSVOg2aA@mail.gmail.com> (raw)
In-Reply-To: <CAFEAcA__BbzvYOxOEQ0iydLJf0WQDDTnaivMWyY2UJeLAcy7HQ@mail.gmail.com>

On 2 March 2018 at 10:29, Peter Maydell <peter.maydell@linaro.org> wrote:
> On 2 March 2018 at 04:34, Alistair Francis <alistair23@gmail.com> wrote:
>>     target/arm: Report the number of cores in the cluster
>>
>>     Previously we assumed that we only has a single cluster, which meant we
>>     could get away with reporting smp_cpus to the guest. There are cases
>>     where we have two clusters (Xilinx's ZynqMP is a good example) so
>>     reporting the number of smp_cpus is incorrect. Instead count the cores
>>     in the cluster.

> This seems a bit ad-hoc (it will give the wrong answer if we have
> two clusters both of the same kind of CPU, for instance).
> Maybe it would be better to have a "cluster-size" property on
> the CPU (with the default being number of cores in whole system) ?

...though I think "cluster size" isn't quite the right name --
if you have a big.LITTLE cluster with 2xA57 and 2xA53, there are
4 cores in the cluster but I think reading the TRM that the cores
will report 2 in the L2CTLR.

thanks
-- PMM

  reply	other threads:[~2018-03-02 10:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-02  0:20 [Qemu-devel] [PATCH v1 1/1] target/arm: Fix the A53 L2CTLR typo Alistair Francis
2018-03-02  4:34 ` Alistair Francis
2018-03-02 10:29   ` Peter Maydell
2018-03-02 10:35     ` Peter Maydell [this message]
2018-03-02 16:17       ` Alistair Francis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFEAcA-RUbtzQSSvyqbG=-PD3kbui1=OdTiY2=rjWtrSVOg2aA@mail.gmail.com' \
    --to=peter.maydell@linaro.org \
    --cc=alistair.francis@xilinx.com \
    --cc=alistair23@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).