From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 315D6C02198 for ; Thu, 6 Feb 2025 15:52:12 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tg49o-0001Fk-T7; Thu, 06 Feb 2025 10:51:13 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tg49n-0001FF-0r for qemu-devel@nongnu.org; Thu, 06 Feb 2025 10:51:11 -0500 Received: from mail-yb1-xb2d.google.com ([2607:f8b0:4864:20::b2d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tg49k-0005fG-EO for qemu-devel@nongnu.org; Thu, 06 Feb 2025 10:51:10 -0500 Received: by mail-yb1-xb2d.google.com with SMTP id 3f1490d57ef6-e549b0f8d57so951842276.3 for ; Thu, 06 Feb 2025 07:51:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1738857066; x=1739461866; darn=nongnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ASDW0A2tZEwrvkv7i8MRxtiQwCq0H8EN+WLjmcNfDFM=; b=VLa4q/JigSAPLjAtP6BBtS6K8fal+6B/n9MTeOK2V/o4RlNdfSANP0IzkTi9OZQajN 96D4JfuxtlNxeZ+vDKE0h5Q1571M0G/WXPCFVk2yBlOXkDT7dsgB8LXP7keJHPfSqRSh 9PURKvDKqz+3hS5OKy6jxOzQLRl73ac4CaS6sylrm/BwWKhflVxSiIDfPWKsRoMjtyCd NY6UkRScvi4D1sGBA2KI6Hi6rSjloyQAxJP5+UckjjVSGn1Fsnt6XWM+5Mb29Q38JNSs d/q5LOu/oA5/zWjn4L7WUsARe9q6HLgUD2BWJZro5/96aJZBRnzb7mJtGXAziEo+hnQG B80Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738857066; x=1739461866; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ASDW0A2tZEwrvkv7i8MRxtiQwCq0H8EN+WLjmcNfDFM=; b=vbrkgp2Ho+lFWhMx/LpS5f8Ry6gt/u/zcUBdWPjtm+SSRJva9PDO6NMbBtRrObAHtq xo92lLV9umHzWpLK95jNtfD4sw/38jqSpFNHehNHZATOLkzE5GyhpoomoMk7bWYlOn8N ZZCzTb8B+i3eHt8ppVOg+ESwFos8x8PsH8sASvv1LqlJXZ9dk47qUue6yCU4Sb8uvWqK 4pJaIK05rWktRIgXYOiZh+UGeUUg5rv29skPEqK4oBWiyC02Cn/oATpqadPWm/WPW31b SaCECj5HsiaPuO5bzOX4gjHGgg/hDmK7byUA1uGt2Y9DTh6OUToFxXt1cKzjfrwQoFxH Os5Q== X-Gm-Message-State: AOJu0YyeDFYHRPiDH660TvbVfm1OaUXZJqTs2aCuC7+lURxX7rp31jnO hbbvZltGXE9oKMKWIBU54Bj8E1AkplJO3PM95DAJ4tTfSjGdjtyP+vztjoZDEcW4i2kNmJ/g4Bf toU/IkHYxbqIDwjGRqhadg0+9ekLDpSpglv7JiAxinlt+GXK1 X-Gm-Gg: ASbGncuTdEriI0oEqRFyHekrGUXStiXTYeKTdCdqR2Z2uqP5dY2eKv721NWTCTwEhfI zfpNrQZ5FkZDG0VHCXXfBuCqR8JjQ4YCbNbOwli6qmIlUTOBmB6Rfa/5jkTtwhWnv40Evnli2Vw == X-Google-Smtp-Source: AGHT+IEVply1qiNn7znAT8fQMFvgeU86wRbWjC73n9GgoJ6MafGCxRH+1m00cw4BFE1qriSGZOIZY/VTW8vN2rZ7ZSM= X-Received: by 2002:a05:6902:2210:b0:e5b:1746:7fa3 with SMTP id 3f1490d57ef6-e5b25bc6f9amr5963299276.23.1738857066557; Thu, 06 Feb 2025 07:51:06 -0800 (PST) MIME-Version: 1.0 References: <20250203144048.2131117-1-alex.bennee@linaro.org> <20250203144048.2131117-5-alex.bennee@linaro.org> In-Reply-To: <20250203144048.2131117-5-alex.bennee@linaro.org> From: Peter Maydell Date: Thu, 6 Feb 2025 15:50:55 +0000 X-Gm-Features: AWEUYZmb9iLML0ZpPW3OB0h1I8Pz0Rcl4bMdig2uKDsyMoFyCdpxYC5JLddP9OM Message-ID: Subject: Re: [PATCH 04/18] tests/qtest: simplify qtest_process_inbuf To: =?UTF-8?B?QWxleCBCZW5uw6ll?= Cc: qemu-devel@nongnu.org, qemu-ppc@nongnu.org, Mahmoud Mandour , Thomas Huth , Daniel Henrique Barboza , Alistair Francis , Hao Wu , Peter Xu , Warner Losh , Pierrick Bouvier , qemu-arm@nongnu.org, Harsh Prateek Bora , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= , Palmer Dabbelt , Kyle Evans , Laurent Vivier , Riku Voipio , Bin Meng , qemu-rust@nongnu.org, Laurent Vivier , Liu Zhiwei , Weiwei Li , qemu-riscv@nongnu.org, Fabiano Rosas , Tyrone Ting , Paolo Bonzini , Nicholas Piggin , Alexandre Iooss Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::b2d; envelope-from=peter.maydell@linaro.org; helo=mail-yb1-xb2d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Mon, 3 Feb 2025 at 14:41, Alex Benn=C3=A9e wrot= e: > > Don't both creating a GString to temporarily hold our qtest command. > Instead do a simpler g_strndup and use autofree to clean up > afterwards. > > Signed-off-by: Alex Benn=C3=A9e > --- Reviewed-by: Peter Maydell thanks -- PMM