From: Peter Maydell <peter.maydell@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>
Cc: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>,
Peter Xu <peterx@redhat.com>,
David Hildenbrand <david@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH-for-8.0 v3 1/2] physmem: Remove unused "exec/translate-all.h"
Date: Fri, 9 Dec 2022 11:43:59 +0000 [thread overview]
Message-ID: <CAFEAcA-ScTH2=2ayQTKy6+_fgj-3kAmQ2Oqxr4bPieimLBKCXw@mail.gmail.com> (raw)
In-Reply-To: <20221209110631.59031-2-philmd@linaro.org>
On Fri, 9 Dec 2022 at 11:07, Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> softmmu/physmem.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/softmmu/physmem.c b/softmmu/physmem.c
> index 1b606a3002..d562c0bb93 100644
> --- a/softmmu/physmem.c
> +++ b/softmmu/physmem.c
> @@ -58,7 +58,6 @@
>
> #include "qemu/rcu_queue.h"
> #include "qemu/main-loop.h"
> -#include "exec/translate-all.h"
> #include "sysemu/replay.h"
>
> #include "exec/memory-internal.h"
> --
physmem.c has a call to tb_check_watchpoint(), which is declared
in translate-all.h -- where does it get the prototype from if
the header isn't included any more ?
thanks
-- PMM
next prev parent reply other threads:[~2022-12-09 11:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-09 11:06 [PATCH-for-8.0 v3 0/2] physmem: Remove trace events from trace-root.h Philippe Mathieu-Daudé
2022-12-09 11:06 ` [PATCH-for-8.0 v3 1/2] physmem: Remove unused "exec/translate-all.h" Philippe Mathieu-Daudé
2022-12-09 11:43 ` Peter Maydell [this message]
2022-12-09 14:10 ` Philippe Mathieu-Daudé
2022-12-09 11:06 ` [PATCH-for-8.0 v3 2/2] physmem: Remove trace events from trace-root.h Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA-ScTH2=2ayQTKy6+_fgj-3kAmQ2Oqxr4bPieimLBKCXw@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=david@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).