From: Peter Maydell <peter.maydell@linaro.org>
To: aurelio remonda <aurelioremonda@gmail.com>
Cc: Liviu Ionescu <ilg@livius.net>,
Daniel Gutson <daniel.gutson@tallertechnologies.com>,
QEMU Developers <qemu-devel@nongnu.org>,
Martin Galvan <martin.galvan@tallertechnologies.com>
Subject: Re: [Qemu-devel] [PATCH V3] Target-arm: Add the Cortex-M4 CPU
Date: Tue, 16 Jun 2015 13:59:48 +0100 [thread overview]
Message-ID: <CAFEAcA-UECMwmMVec-LQVwLGWF-+FELfjwY2me_n1vQX4pezpg@mail.gmail.com> (raw)
In-Reply-To: <CAE_j2pt4j8n-6DxYFJ=97tEH2gypLC-3bGX54P_ga1EPm7SDdw@mail.gmail.com>
On 16 June 2015 at 13:52, aurelio remonda <aurelioremonda@gmail.com> wrote:
> about the space between ARMCPU *cpu = ARM_CPU(obj); line and the first
> set_feature, the cortex-m3 initfn does not have it, do you want me to
> change that one too? Thanks
I would leave that one alone. It's bad style, but fixing
it should be a separate patch, and it isn't sufficiently
bad to be worth fixing IMHO.
-- PMM
prev parent reply other threads:[~2015-06-16 13:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-15 20:31 [Qemu-devel] [PATCH V3] Target-arm: Add the Cortex-M4 CPU Aurelio C. Remonda
2015-06-16 11:21 ` Peter Maydell
2015-06-16 12:25 ` aurelio remonda
2015-06-16 12:29 ` Liviu Ionescu
2015-06-16 12:52 ` aurelio remonda
2015-06-16 12:59 ` Peter Maydell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA-UECMwmMVec-LQVwLGWF-+FELfjwY2me_n1vQX4pezpg@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=aurelioremonda@gmail.com \
--cc=daniel.gutson@tallertechnologies.com \
--cc=ilg@livius.net \
--cc=martin.galvan@tallertechnologies.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).