From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53085)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1Z4qTO-0003FV-3G
	for qemu-devel@nongnu.org; Tue, 16 Jun 2015 09:00:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1Z4qTK-00040c-3t
	for qemu-devel@nongnu.org; Tue, 16 Jun 2015 09:00:14 -0400
Received: from mail-yk0-f169.google.com ([209.85.160.169]:33067)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1Z4qTK-00040V-0u
	for qemu-devel@nongnu.org; Tue, 16 Jun 2015 09:00:10 -0400
Received: by ykfr66 with SMTP id r66so12436674ykf.0
	for <qemu-devel@nongnu.org>; Tue, 16 Jun 2015 06:00:09 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <CAE_j2pt4j8n-6DxYFJ=97tEH2gypLC-3bGX54P_ga1EPm7SDdw@mail.gmail.com>
References: <1434400260-5191-1-git-send-email-aurelioremonda@gmail.com>
	<CAFEAcA-FLiQnXd1GgkkDtwsw_SGHc5ufbPwK41pRTC6fFWxYcA@mail.gmail.com>
	<E5DE967E-7E1A-46C7-A21E-0810FA524EC5@livius.net>
	<CAE_j2pt4j8n-6DxYFJ=97tEH2gypLC-3bGX54P_ga1EPm7SDdw@mail.gmail.com>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Tue, 16 Jun 2015 13:59:48 +0100
Message-ID: <CAFEAcA-UECMwmMVec-LQVwLGWF-+FELfjwY2me_n1vQX4pezpg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH V3] Target-arm: Add the Cortex-M4 CPU
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: aurelio remonda <aurelioremonda@gmail.com>
Cc: Liviu Ionescu <ilg@livius.net>, Daniel Gutson <daniel.gutson@tallertechnologies.com>, QEMU Developers <qemu-devel@nongnu.org>, Martin Galvan <martin.galvan@tallertechnologies.com>

On 16 June 2015 at 13:52, aurelio remonda <aurelioremonda@gmail.com> wrote:
> about the space between ARMCPU *cpu = ARM_CPU(obj); line and the first
> set_feature, the cortex-m3 initfn does not have it, do you want me to
> change that one too? Thanks

I would leave that one alone. It's bad style, but fixing
it should be a separate patch, and it isn't sufficiently
bad to be worth fixing IMHO.

-- PMM