From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:45367)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1T8cjY-0002Un-LN
	for qemu-devel@nongnu.org; Mon, 03 Sep 2012 15:54:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1T8cjX-0007Dw-J1
	for qemu-devel@nongnu.org; Mon, 03 Sep 2012 15:54:56 -0400
Received: from mail-ie0-f173.google.com ([209.85.223.173]:54756)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1T8cjX-0007Dp-EI
	for qemu-devel@nongnu.org; Mon, 03 Sep 2012 15:54:55 -0400
Received: by iebc10 with SMTP id c10so3681533ieb.4
	for <qemu-devel@nongnu.org>; Mon, 03 Sep 2012 12:54:54 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <CAAu8pHtvB71+H_JGKFZ3jbcreacB8MqWcr_s62GuKTd2=sXJ=w@mail.gmail.com>
References: <cover.1346606812.git.blauwirbel@gmail.com>
	<479cafb3637c07c69ef37e54037c2d42103cdc3e.1346606813.git.blauwirbel@gmail.com>
	<CAFEAcA-GXYozZwp0f962RWeacygVtB91bGWNnrBZqqmafFP=8Q@mail.gmail.com>
	<CAFEAcA8Y6R37mPe0SmU4q+vw92gX8Sidr65ijdB8ZmU_Pt=HDQ@mail.gmail.com>
	<CAAu8pHtvB71+H_JGKFZ3jbcreacB8MqWcr_s62GuKTd2=sXJ=w@mail.gmail.com>
Date: Mon, 3 Sep 2012 20:54:54 +0100
Message-ID: <CAFEAcA-UYNqqMTjCLaGKji=cMuy-0=MKYguybZ_i6JYAPDj-GA@mail.gmail.com>
From: Peter Maydell <peter.maydell@linaro.org>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH 16/21] target-arm: switch to AREG0 free mode
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel@nongnu.org, Paul Brook <paul@codesourcery.com>

On 3 September 2012 19:58, Blue Swirl <blauwirbel@gmail.com> wrote:
> On Mon, Sep 3, 2012 at 12:03 AM, Peter Maydell <peter.maydell@linaro.org> wrote:
>> On 3 September 2012 01:01, Peter Maydell <peter.maydell@linaro.org> wrote:
>> That's quite hard to cross-reference when the patch is this big.
>> I think it would be helpful if you could split it up into patches
>> touching smaller groups of helpers at once rather than having a
>> single patch that does them all at once.
>
> For x86, Sparc and s390x I used the approach of splitting op_helper.c
> to smaller files first. I didn't do it for ARM since
> target-arm/op_helper.c is alread pretty small (<500 lines). It could
> be split to saturating ops, condition code setting arithmetic ops and
> misc ops, between 100 and 200 lines each. Would that be OK?

I don't want the *file* split, I'd just like to see this *patch*
as 4 or 5 separate patches, not one big one.

(Patch-splitting is a personal preference thing; I generally favour
lots of little patches over big ones.)

thanks
-- PMM