From: Peter Maydell <peter.maydell@linaro.org>
To: Shannon Zhao <zhaoshenglong@huawei.com>
Cc: qemu-arm <qemu-arm@nongnu.org>,
Eric Auger <eric.auger@redhat.com>,
qemu-stable <qemu-stable@nongnu.org>,
QEMU Developers <qemu-devel@nongnu.org>,
Shannon Zhao <shannon.zhaosl@gmail.com>
Subject: Re: [Qemu-devel] [Qemu-arm] [PATCH v4 1/2] arm_gicv3_kvm: kvm_dist_get/put_priority: skip the registers banked by GICR_IPRIORITYR
Date: Tue, 29 May 2018 15:20:19 +0100 [thread overview]
Message-ID: <CAFEAcA-Um2dCAUJ2uxjZW6foBsrEYMnKNmFwex=kD63vLUJ2Ww@mail.gmail.com> (raw)
In-Reply-To: <1527247371-10592-2-git-send-email-zhaoshenglong@huawei.com>
On 25 May 2018 at 12:22, Shannon Zhao <zhaoshenglong@huawei.com> wrote:
> While for_each_dist_irq_reg loop starts from GIC_INTERNAL, it forgot to
> offset the date array and index. This will overlap the GICR registers
> value and leave the last GIC_INTERNAL irq's registers out of update.
>
> Fixes: 367b9f527becdd20ddf116e17a3c0c2bbc486920
> Cc: qemu-stable@nongnu.org
> Signed-off-by: Shannon Zhao <zhaoshenglong@huawei.com>
> ---
> hw/intc/arm_gicv3_kvm.c | 18 ++++++++++++++++--
> 1 file changed, 16 insertions(+), 2 deletions(-)
>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
next prev parent reply other threads:[~2018-05-29 14:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-25 11:22 [Qemu-devel] [PATCH v4 0/2] Fix ARM KVM GICv3 get/put data shift bug Shannon Zhao
2018-05-25 11:22 ` [Qemu-devel] [PATCH v4 1/2] arm_gicv3_kvm: kvm_dist_get/put_priority: skip the registers banked by GICR_IPRIORITYR Shannon Zhao
2018-05-29 14:20 ` Peter Maydell [this message]
2018-05-25 11:22 ` [Qemu-devel] [PATCH v4 2/2] arm_gicv3_kvm: kvm_dist_get/put: skip the registers banked by GICR Shannon Zhao
2018-05-29 14:44 ` [Qemu-devel] [Qemu-arm] " Peter Maydell
2018-05-30 1:42 ` Shannon Zhao
2018-05-31 10:02 ` Peter Maydell
2018-05-25 11:36 ` [Qemu-devel] [PATCH v4 0/2] Fix ARM KVM GICv3 get/put data shift bug no-reply
2018-05-26 0:41 ` Shannon Zhao
2018-05-25 11:39 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA-Um2dCAUJ2uxjZW6foBsrEYMnKNmFwex=kD63vLUJ2Ww@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=eric.auger@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=shannon.zhaosl@gmail.com \
--cc=zhaoshenglong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).