From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34579) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fNfUP-00004r-BO for qemu-devel@nongnu.org; Tue, 29 May 2018 10:20:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fNfUO-0006y1-JW for qemu-devel@nongnu.org; Tue, 29 May 2018 10:20:41 -0400 Received: from mail-oi0-x243.google.com ([2607:f8b0:4003:c06::243]:37978) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fNfUO-0006xj-Ep for qemu-devel@nongnu.org; Tue, 29 May 2018 10:20:40 -0400 Received: by mail-oi0-x243.google.com with SMTP id d5-v6so10166522oib.5 for ; Tue, 29 May 2018 07:20:40 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1527247371-10592-2-git-send-email-zhaoshenglong@huawei.com> References: <1527247371-10592-1-git-send-email-zhaoshenglong@huawei.com> <1527247371-10592-2-git-send-email-zhaoshenglong@huawei.com> From: Peter Maydell Date: Tue, 29 May 2018 15:20:19 +0100 Message-ID: Content-Type: text/plain; charset="UTF-8" Subject: Re: [Qemu-devel] [Qemu-arm] [PATCH v4 1/2] arm_gicv3_kvm: kvm_dist_get/put_priority: skip the registers banked by GICR_IPRIORITYR List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Shannon Zhao Cc: qemu-arm , Eric Auger , qemu-stable , QEMU Developers , Shannon Zhao On 25 May 2018 at 12:22, Shannon Zhao wrote: > While for_each_dist_irq_reg loop starts from GIC_INTERNAL, it forgot to > offset the date array and index. This will overlap the GICR registers > value and leave the last GIC_INTERNAL irq's registers out of update. > > Fixes: 367b9f527becdd20ddf116e17a3c0c2bbc486920 > Cc: qemu-stable@nongnu.org > Signed-off-by: Shannon Zhao > --- > hw/intc/arm_gicv3_kvm.c | 18 ++++++++++++++++-- > 1 file changed, 16 insertions(+), 2 deletions(-) > Reviewed-by: Peter Maydell thanks -- PMM