From: Peter Maydell <peter.maydell@linaro.org>
To: Jean-Christophe DUBOIS <jcd@tribudubois.net>
Cc: peter.crosthwaite@xilinx.com, peter.chubb@nicta.com.au,
qemu-devel@nongnu.org, afaerber@suse.de
Subject: Re: [Qemu-devel] [PATCH v5 1/4] Add i.MX FEC Ethernet emulator
Date: Mon, 3 Jun 2013 16:12:31 +0100 [thread overview]
Message-ID: <CAFEAcA-W-w2WHmAVZPfjd6ZG7MtkF2ALRAF-OK_BSmzj8rDysQ@mail.gmail.com> (raw)
In-Reply-To: <962ac7936351d2ffa236ef14770dad20fca21fbc.1368001258.git.jcd@tribudubois.net>
On 8 May 2013 09:28, Jean-Christophe DUBOIS <jcd@tribudubois.net> wrote:
> --- a/include/hw/arm/imx.h
> +++ b/include/hw/arm/imx.h
> @@ -23,12 +23,10 @@ typedef enum {
>
> uint32_t imx_clock_frequency(DeviceState *s, IMXClk clock);
>
> -void imx_timerp_create(const hwaddr addr,
> - qemu_irq irq,
> - DeviceState *ccm);
> -void imx_timerg_create(const hwaddr addr,
> - qemu_irq irq,
> - DeviceState *ccm);
> +void imx_timerp_create(const hwaddr addr, qemu_irq irq, DeviceState *ccm);
>
> +void imx_timerg_create(const hwaddr addr, qemu_irq irq, DeviceState *ccm);
> +
Please don't include random reformatting inside a patch
doing something else.
> +DeviceState *imx_fec_create(int nic, const hwaddr base, qemu_irq irq);
thanks
-- PMM
next prev parent reply other threads:[~2013-06-03 15:13 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-08 8:28 [Qemu-devel] [PATCH v5 0/4] Add i.MX25 support through the 3DS evaluation board Jean-Christophe DUBOIS
2013-05-08 8:28 ` [Qemu-devel] [PATCH v5 1/4] Add i.MX FEC Ethernet emulator Jean-Christophe DUBOIS
2013-05-24 5:38 ` Peter Crosthwaite
2013-06-03 15:12 ` Peter Maydell [this message]
2013-05-08 8:28 ` [Qemu-devel] [PATCH v5 2/4] Add i.MX I2C controller emulator Jean-Christophe DUBOIS
2013-05-24 5:29 ` Peter Crosthwaite
2013-06-03 15:14 ` Peter Maydell
2013-05-08 8:28 ` [Qemu-devel] [PATCH v5 3/4] Add i.MX25 3DS evaluation board support Jean-Christophe DUBOIS
2013-06-03 15:18 ` Peter Maydell
2013-05-08 8:28 ` [Qemu-devel] [PATCH v5 4/4] Add qtest support for i.MX I2C device emulation Jean-Christophe DUBOIS
2013-06-03 15:21 ` Peter Maydell
2013-06-04 3:24 ` Peter Crosthwaite
2013-06-04 18:41 ` Jean-Christophe DUBOIS
2013-05-12 12:55 ` [Qemu-devel] [PATCH v5 0/4] Add i.MX25 support through the 3DS evaluation board Jean-Christophe DUBOIS
2013-05-12 13:14 ` Peter Maydell
2013-06-03 15:23 ` Peter Maydell
2013-06-04 18:23 ` Jean-Christophe DUBOIS
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA-W-w2WHmAVZPfjd6ZG7MtkF2ALRAF-OK_BSmzj8rDysQ@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=afaerber@suse.de \
--cc=jcd@tribudubois.net \
--cc=peter.chubb@nicta.com.au \
--cc=peter.crosthwaite@xilinx.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).