From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46376)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1UjWRQ-00054e-0y
	for qemu-devel@nongnu.org; Mon, 03 Jun 2013 11:13:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1UjWRI-0005ce-Ks
	for qemu-devel@nongnu.org; Mon, 03 Jun 2013 11:12:59 -0400
Received: from mail-lb0-f171.google.com ([209.85.217.171]:58920)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1UjWRI-0005bz-8O
	for qemu-devel@nongnu.org; Mon, 03 Jun 2013 11:12:52 -0400
Received: by mail-lb0-f171.google.com with SMTP id v5so1140784lbc.30
	for <qemu-devel@nongnu.org>; Mon, 03 Jun 2013 08:12:51 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <962ac7936351d2ffa236ef14770dad20fca21fbc.1368001258.git.jcd@tribudubois.net>
References: <cover.1368001258.git.jcd@tribudubois.net>
	<962ac7936351d2ffa236ef14770dad20fca21fbc.1368001258.git.jcd@tribudubois.net>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Mon, 3 Jun 2013 16:12:31 +0100
Message-ID: <CAFEAcA-W-w2WHmAVZPfjd6ZG7MtkF2ALRAF-OK_BSmzj8rDysQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH v5 1/4] Add i.MX FEC Ethernet emulator
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jean-Christophe DUBOIS <jcd@tribudubois.net>
Cc: peter.crosthwaite@xilinx.com, peter.chubb@nicta.com.au, qemu-devel@nongnu.org, afaerber@suse.de

On 8 May 2013 09:28, Jean-Christophe DUBOIS <jcd@tribudubois.net> wrote:
> --- a/include/hw/arm/imx.h
> +++ b/include/hw/arm/imx.h
> @@ -23,12 +23,10 @@ typedef enum  {
>
>  uint32_t imx_clock_frequency(DeviceState *s, IMXClk clock);
>
> -void imx_timerp_create(const hwaddr addr,
> -                      qemu_irq irq,
> -                      DeviceState *ccm);
> -void imx_timerg_create(const hwaddr addr,
> -                      qemu_irq irq,
> -                      DeviceState *ccm);
> +void imx_timerp_create(const hwaddr addr, qemu_irq irq, DeviceState *ccm);
>
> +void imx_timerg_create(const hwaddr addr, qemu_irq irq, DeviceState *ccm);
> +

Please don't include random reformatting inside a patch
doing something else.

> +DeviceState *imx_fec_create(int nic, const hwaddr base, qemu_irq irq);

thanks
-- PMM