From: Peter Maydell <peter.maydell@linaro.org>
To: Markus Armbruster <armbru@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2] hmp: gpa2hva and gpa2hpa hostaddr command
Date: Mon, 20 Mar 2017 16:32:06 +0000 [thread overview]
Message-ID: <CAFEAcA-XZ-STrvzv4nrxrMCd3ureKXpLeAFpoPktNYb++YMusQ@mail.gmail.com> (raw)
In-Reply-To: <87bmsv29ok.fsf@dusky.pond.sub.org>
On 20 March 2017 at 16:29, Markus Armbruster <armbru@redhat.com> wrote:
> Peter Maydell <peter.maydell@linaro.org> writes:
>> I have some comments which feel kind of nit-picky, but since this
>> is a public-facing HMP API I think they need attention since we only
>> get one chance to get it right.
>
> HMP is not a stable interface. If we get it wrong, we change it. If
> our change breaks your usage, you get to keep the pieces.
Oh yes, I had my HMP and QMP the wrong way round.
...which reminds me that I thought we preferred all HMP commands
to be implemented in terms of their QMP equivalent ?
thanks
-- PMM
next prev parent reply other threads:[~2017-03-20 16:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-20 14:45 [Qemu-devel] [PATCH v2] hmp: gpa2hva and gpa2hpa hostaddr command Paolo Bonzini
2017-03-20 14:56 ` Peter Maydell
2017-03-20 15:08 ` Paolo Bonzini
2017-03-20 16:29 ` Markus Armbruster
2017-03-20 16:32 ` Peter Maydell [this message]
2017-03-20 16:35 ` Paolo Bonzini
2017-03-20 17:01 ` Markus Armbruster
2017-03-20 17:16 ` Paolo Bonzini
2017-03-24 21:56 ` Paolo Bonzini
2017-03-27 9:25 ` Dr. David Alan Gilbert
2017-03-27 15:35 ` Dr. David Alan Gilbert
2017-03-20 14:59 ` Dr. David Alan Gilbert
2017-03-27 13:49 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA-XZ-STrvzv4nrxrMCd3ureKXpLeAFpoPktNYb++YMusQ@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).