From: Peter Maydell <peter.maydell@linaro.org>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: qemu-devel@nongnu.org, qemu-arm@nongnu.org
Subject: Re: [PATCH 6/7] target/arm: Honor param.aie in get_phys_addr_lpae
Date: Mon, 13 Oct 2025 14:50:30 +0100 [thread overview]
Message-ID: <CAFEAcA-Y6fHULs167FZBFTAOo0FuPdVvaPtPb2ihXWkf=e4gfQ@mail.gmail.com> (raw)
In-Reply-To: <20251010201917.685716-7-richard.henderson@linaro.org>
On Fri, 10 Oct 2025 at 21:21, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> target/arm/ptw.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/target/arm/ptw.c b/target/arm/ptw.c
> index 5fcf104272..23f6616811 100644
> --- a/target/arm/ptw.c
> +++ b/target/arm/ptw.c
> @@ -2319,7 +2319,9 @@ static bool get_phys_addr_lpae(CPUARMState *env, S1Translate *ptw,
>
> /* Index into MAIR registers for cache attributes */
> attrindx = extract32(attrs, 2, 3);
> - mair = env->cp15.mair_el[el];
> + mair = (param.aie && extract64(attrs, 59, 1)
> + ? env->cp15.mair2_el[el]
> + : env->cp15.mair_el[el]);
> result->cacheattrs.is_s2_format = false;
> result->cacheattrs.attrs = extract64(mair, attrindx * 8, 8);
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
next prev parent reply other threads:[~2025-10-13 13:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-10 20:19 [PATCH 0/7] target/arm: Implement FEAT_AIE Richard Henderson
2025-10-10 20:19 ` [PATCH 1/7] target/arm: Add isar feature test for FEAT_AIE Richard Henderson
2025-10-13 13:35 ` Peter Maydell
2025-10-10 20:19 ` [PATCH 2/7] target/arm: Implement MAIR2_ELx and AMAIR2_ELx Richard Henderson
2025-10-13 13:55 ` Peter Maydell
2025-10-10 20:19 ` [PATCH 3/7] target/arm: Add AIE to ARMVAParameters Richard Henderson
2025-10-13 14:05 ` Peter Maydell
2025-10-10 20:19 ` [PATCH 4/7] target/arm: Drop trivial assert vs attrindx Richard Henderson
2025-10-13 13:44 ` Peter Maydell
2025-10-10 20:19 ` [PATCH 5/7] target/arm: Use el local indexing mair_el Richard Henderson
2025-10-13 13:36 ` Peter Maydell
2025-10-10 20:19 ` [PATCH 6/7] target/arm: Honor param.aie in get_phys_addr_lpae Richard Henderson
2025-10-13 13:50 ` Peter Maydell [this message]
2025-10-10 20:19 ` [PATCH 7/7] target/arm: Enable FEAT_AIE for -cpu max Richard Henderson
2025-10-13 13:44 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA-Y6fHULs167FZBFTAOo0FuPdVvaPtPb2ihXWkf=e4gfQ@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).