From: Peter Maydell <peter.maydell@linaro.org>
To: Akihiko Odaki <akihiko.odaki@daynix.com>
Cc: qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH] util: Delete a check for IA-64
Date: Tue, 8 Aug 2023 16:23:30 +0100 [thread overview]
Message-ID: <CAFEAcA-YuQBkoSE78jMzVFXt5GuJHYAO36U2okHbn1_hSXHkzg@mail.gmail.com> (raw)
In-Reply-To: <20230808152026.100096-1-akihiko.odaki@daynix.com>
On Tue, 8 Aug 2023 at 16:21, Akihiko Odaki <akihiko.odaki@daynix.com> wrote:
>
> HOST_IA64 will never be defined since IA-64 host is no longer supported.
>
> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
> ---
> util/oslib-posix.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/util/oslib-posix.c b/util/oslib-posix.c
> index 760390b31e..f7adb36dfb 100644
> --- a/util/oslib-posix.c
> +++ b/util/oslib-posix.c
> @@ -618,10 +618,7 @@ void *qemu_alloc_stack(size_t *sz)
> abort();
> }
>
> -#if defined(HOST_IA64)
> - /* separate register stack */
> - guardpage = ptr + (((*sz - pagesz) / 2) & ~pagesz);
> -#elif defined(HOST_HPPA)
> +#if defined(HOST_HPPA)
> /* stack grows up */
> guardpage = ptr + *sz - pagesz;
> #else
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
(There's another one in include/exec/user/thunk.h.)
thanks
-- PMM
next prev parent reply other threads:[~2023-08-08 15:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-08 15:20 [PATCH] util: Delete a check for IA-64 Akihiko Odaki
2023-08-08 15:23 ` Peter Maydell [this message]
2023-08-10 10:52 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA-YuQBkoSE78jMzVFXt5GuJHYAO36U2okHbn1_hSXHkzg@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=akihiko.odaki@daynix.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).