From: Peter Maydell <peter.maydell@linaro.org>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
Patch Tracking <patches@linaro.org>
Subject: Re: [Qemu-devel] [PATCH] target-sh4: Use glib allocator in movcal helper
Date: Fri, 22 Jul 2016 12:06:26 +0100 [thread overview]
Message-ID: <CAFEAcA-_3-njdBfsWki4L8ouu3hM6X0zAf6PLRSzfYLhed26og@mail.gmail.com> (raw)
In-Reply-To: <20160721162834.GA23477@aurel32.net>
On 21 July 2016 at 17:28, Aurelien Jarno <aurelien@aurel32.net> wrote:
> On 2016-07-21 13:44, Peter Maydell wrote:
>> Ping?
>>
>> thanks
>> -- PMM
>>
>> On 12 July 2016 at 13:50, Peter Maydell <peter.maydell@linaro.org> wrote:
>> > Coverity spots that helper_movcal() calls malloc() but doesn't
>> > check for failure. Fix this by switching to the glib allocation
>> > functions, which abort on allocation failure.
>> >
>> > Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
>> > ---
>> > target-sh4/op_helper.c | 7 ++++---
>> > 1 file changed, 4 insertions(+), 3 deletions(-)
>
> I have just looked at it and test it. It's all fine, sorry for the
> delay.
>
> Acked-by: Aurelien Jarno <aurelien@aurel32.net>
Applied to master, thanks.
-- PMM
prev parent reply other threads:[~2016-07-22 11:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-12 12:50 [Qemu-devel] [PATCH] target-sh4: Use glib allocator in movcal helper Peter Maydell
2016-07-21 12:44 ` Peter Maydell
2016-07-21 16:28 ` Aurelien Jarno
2016-07-22 11:06 ` Peter Maydell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA-_3-njdBfsWki4L8ouu3hM6X0zAf6PLRSzfYLhed26og@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=aurelien@aurel32.net \
--cc=patches@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).