From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59732)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1bQYI6-0007Qq-2h
	for qemu-devel@nongnu.org; Fri, 22 Jul 2016 07:06:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1bQYI4-0002zp-0X
	for qemu-devel@nongnu.org; Fri, 22 Jul 2016 07:06:49 -0400
Received: from mail-vk0-x22d.google.com ([2607:f8b0:400c:c05::22d]:33753)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1bQYI2-0002zd-N5
	for qemu-devel@nongnu.org; Fri, 22 Jul 2016 07:06:47 -0400
Received: by mail-vk0-x22d.google.com with SMTP id x130so152500659vkc.0
	for <qemu-devel@nongnu.org>; Fri, 22 Jul 2016 04:06:46 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <20160721162834.GA23477@aurel32.net>
References: <1468327859-21385-1-git-send-email-peter.maydell@linaro.org>
	<CAFEAcA_p9TiXpcKLqKaD1PCR_gV_G+o=GFwfLQT02R+FpYOXRQ@mail.gmail.com>
	<20160721162834.GA23477@aurel32.net>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Fri, 22 Jul 2016 12:06:26 +0100
Message-ID: <CAFEAcA-_3-njdBfsWki4L8ouu3hM6X0zAf6PLRSzfYLhed26og@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH] target-sh4: Use glib allocator in movcal
 helper
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: QEMU Developers <qemu-devel@nongnu.org>, Patch Tracking <patches@linaro.org>

On 21 July 2016 at 17:28, Aurelien Jarno <aurelien@aurel32.net> wrote:
> On 2016-07-21 13:44, Peter Maydell wrote:
>> Ping?
>>
>> thanks
>> -- PMM
>>
>> On 12 July 2016 at 13:50, Peter Maydell <peter.maydell@linaro.org> wrote:
>> > Coverity spots that helper_movcal() calls malloc() but doesn't
>> > check for failure. Fix this by switching to the glib allocation
>> > functions, which abort on allocation failure.
>> >
>> > Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
>> > ---
>> >  target-sh4/op_helper.c | 7 ++++---
>> >  1 file changed, 4 insertions(+), 3 deletions(-)
>
> I have just looked at it and test it. It's all fine, sorry for the
> delay.
>
> Acked-by: Aurelien Jarno <aurelien@aurel32.net>

Applied to master, thanks.

-- PMM