From: Peter Maydell <peter.maydell@linaro.org>
To: mjaggi@caviumnetworks.com
Cc: "Jaggi, Manish" <Manish.Jaggi@cavium.com>,
"quintela@redhat.com" <quintela@redhat.com>,
"dgilbert@redhat.com" <dgilbert@redhat.com>,
"eric.auger@redhat.com" <eric.auger@redhat.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"Nair, Jayachandran" <Jayachandran.Nair@cavium.com>,
"Nowicki, Tomasz" <Tomasz.Nowicki@cavium.com>
Subject: Re: [Qemu-devel] [RFC] [PATCH 0/3] qemu: arm: Migration between machines with different MIDR values
Date: Tue, 2 Oct 2018 14:07:38 +0100 [thread overview]
Message-ID: <CAFEAcA-_5MzdykGKja1sJggx2QVOUXT69NF-Ya2sE8RZFu53fA@mail.gmail.com> (raw)
In-Reply-To: <cover.1537868529.git.manish.jaggi@cavium.com>
On 27 September 2018 at 02:13, <mjaggi@caviumnetworks.com> wrote:
> From: Manish Jaggi <manish.jaggi@cavium.com>
>
> QEMU on arm systems use -machine virt -cpu host option for a VM.
> Migration thus is limited between machines with same cpu.
>
> This is a limitation if migration is desired between cpus which are of same
> family and have only few diferences like bug fixes which have no effect on
> VM operation. They just differ in say MIDR values.
>
> This patchset introduces a command line option -skipinvariant. Invariant
> registers will be skipped from being restored from guests context on migrated
> host.
>
> Mailing list discussion on this topic:
> https://www.mail-archive.com/qemu-devel@nongnu.org/msg560043.html
Hi; thanks for this patch. The issue I see with this patch
is that the KVM/ARM QEMU approach to system registers so far
has been "the kernel knows about these and it is in control".
So we ask the kernel for the list of registers, and just save
and restore those. That would suggest that if there are sysregs
where it's OK in fact to ignore a difference between two constant
register values, it should be the kernel doing the "actually, this
mismatch is OK" behaviour...
For instance, it's probably OK to ignore a MIDR_EL1 difference
that just indicates a minor revision bump; but not to ignore
one that indicates you just tried to migrate a Cortex-A53
over to a Cavium CPU.
thanks
-- PMM
next parent reply other threads:[~2018-10-02 13:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1537868529.git.manish.jaggi@cavium.com>
2018-10-02 13:07 ` Peter Maydell [this message]
2018-10-04 15:05 ` [Qemu-devel] [RFC] [PATCH 0/3] qemu: arm: Migration between machines with different MIDR values Andrew Jones
2018-10-04 15:26 ` Peter Maydell
2018-10-05 8:48 ` Dr. David Alan Gilbert
2018-10-05 9:17 ` Peter Maydell
[not found] ` <2a127056e5c1a1edb4a5d8e093bc67467685e0ac.1537868529.git.manish.jaggi@cavium.com>
2018-10-04 15:15 ` [Qemu-devel] [RFC] [PATCH 3/3] arm: Skip invariant register restore Andrew Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA-_5MzdykGKja1sJggx2QVOUXT69NF-Ya2sE8RZFu53fA@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=Jayachandran.Nair@cavium.com \
--cc=Manish.Jaggi@cavium.com \
--cc=Tomasz.Nowicki@cavium.com \
--cc=dgilbert@redhat.com \
--cc=eric.auger@redhat.com \
--cc=mjaggi@caviumnetworks.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).