From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49284) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cjpbI-0001HY-5d for qemu-devel@nongnu.org; Fri, 03 Mar 2017 10:58:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cjpbH-0006vC-B7 for qemu-devel@nongnu.org; Fri, 03 Mar 2017 10:58:36 -0500 Received: from mail-wr0-x236.google.com ([2a00:1450:400c:c0c::236]:33058) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cjpbH-0006uq-4U for qemu-devel@nongnu.org; Fri, 03 Mar 2017 10:58:35 -0500 Received: by mail-wr0-x236.google.com with SMTP id u48so76627141wrc.0 for ; Fri, 03 Mar 2017 07:58:34 -0800 (PST) MIME-Version: 1.0 In-Reply-To: References: <8FB6923C-8F97-497C-95DC-6F2D937725BC@gmail.com> <20170303164426.42472535@bahia.lan> From: Peter Maydell Date: Fri, 3 Mar 2017 15:58:13 +0000 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] git master build failure in 9pfs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: G 3 Cc: Greg Kurz , Mark Cave-Ayland , qemu-devel qemu-devel On 3 March 2017 at 15:55, G 3 wrote: > Here is the patch. I think we should let Mark or some else test it to see if > it does fix the problem before a real patch is submitted. > > --- > hw/9pfs/9p-util.h | 4 ++++ > 1 file changed, 4 insertions(+) We can't take any patch without a Signed-off-by: line, not even a three line one. > > diff --git a/hw/9pfs/9p-util.h b/hw/9pfs/9p-util.h > index 091f3ce..254d2a9 100644 > --- a/hw/9pfs/9p-util.h > +++ b/hw/9pfs/9p-util.h > @@ -13,6 +13,10 @@ > #ifndef QEMU_9P_UTIL_H > #define QEMU_9P_UTIL_H > > +#ifndef O_PATH > + #define O_PATH 0 > +#endif Could use a comment explaining why it's OK to define it in a way that means it's a no-op on hosts without it. > + > static inline void close_preserve_errno(int fd) > { > int serrno = errno; > -- > 2.10.2 thanks -- PMM