From: Peter Maydell <peter.maydell@linaro.org>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: Marcin Chojnacki <marcinch7@gmail.com>,
qemu-arm <qemu-arm@nongnu.org>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [Qemu-arm] [PATCH v2] target-arm: Implement BCM2835 hardware RNG
Date: Sat, 11 Feb 2017 13:14:50 +0000 [thread overview]
Message-ID: <CAFEAcA-_wAWiewc2NX7RrfBN3UFc=9dY2tDri-rkNTs2=pFs2Q@mail.gmail.com> (raw)
In-Reply-To: <8737flj70j.fsf@linaro.org>
On 11 February 2017 at 11:34, Alex Bennée <alex.bennee@linaro.org> wrote:
> I know we are running under emulation but is rand() the right call to
> feed data to the guest? There is the virtio rng and PPC spar RNG which
> both use rng_backend_request_entropy() to collect random data. We should
> probably make the Pi RNG as good as the other guests.
See discussion on v1 of this patch -- the rng backend is probably
the right idea but its API is a huge pain in the neck. I suggested
Marcin do a v2 which still uses rand() so we can get everything
else reviewed, and then deal with the rng stuff separately.
(Notably I think that for the rng backend you have to on the
command line create and wire up a backend, which is a lot
of pain. There doesn't seem to be any kind of "use a sane
default" available :-( )
thanks
-- PMM
next prev parent reply other threads:[~2017-02-11 13:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-10 21:08 [Qemu-devel] [PATCH v2] target-arm: Implement BCM2835 hardware RNG Marcin Chojnacki
2017-02-11 11:34 ` [Qemu-devel] [Qemu-arm] " Alex Bennée
2017-02-11 13:14 ` Peter Maydell [this message]
2017-02-17 12:54 ` [Qemu-devel] " Peter Maydell
2017-02-17 15:38 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA-_wAWiewc2NX7RrfBN3UFc=9dY2tDri-rkNTs2=pFs2Q@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=marcinch7@gmail.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).