From: Peter Maydell <peter.maydell@linaro.org>
To: James Hanley <jhanley@dgtlrift.com>
Cc: qemu-devel <qemu-devel@nongnu.org>,
Vincent Palatin <vpalatin@chromium.org>
Subject: Re: [Qemu-devel] changeset b0cb0a66d broken - missing QEMU_OPTION_enable_hax
Date: Mon, 23 Jan 2017 19:41:48 +0000 [thread overview]
Message-ID: <CAFEAcA-aEA9cNzd6cJchrdojyX7xKr4eOKECkMEen=fhGucCPA@mail.gmail.com> (raw)
In-Reply-To: <CAF++6APW69OBEzfUaWXK-kXLY5euu8aJjvFrYzwFT1tes-W=gA@mail.gmail.com>
On 23 January 2017 at 19:32, James Hanley <jhanley@dgtlrift.com> wrote:
> Changeset fails to compile:
>
> qemu/vl.c:3683:18: error: ‘QEMU_OPTION_enable_hax’ undeclared (first use in
> this function)
> case QEMU_OPTION_enable_hax:
> ^
> I assume that there is details in
>
> ./qemu-options.def
> ./qemu-options.hx
>
> that were not included with the commit?
Your source tree probably has a stale qemu-options.def in it
from an attempt to do an in-tree build at some point in the
past (and now you are doing out-of-tree builds). If you do a
'make distclean' in the source tree this will get rid of the
stale junk and the build should work. (Or you can just git
clone a fresh tree; or attempt to more carefully remove
individual stale stuff, but that risks leaving some other
stale file around.)
(The change to qemu-options.hx is sufficient, because we
generate qemu-options.def from it in the build tree; but
if you have a stale .def file in the source tree then
gcc will pick that one up before the one in the build tree;
which works until something requires a change that postdates
the stale stuff.)
thanks
-- PMM
next prev parent reply other threads:[~2017-01-23 19:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-23 19:32 [Qemu-devel] changeset b0cb0a66d broken - missing QEMU_OPTION_enable_hax James Hanley
2017-01-23 19:41 ` Peter Maydell [this message]
2017-01-23 19:55 ` James Hanley
2017-01-24 17:28 ` Michael S. Tsirkin
2017-01-24 17:56 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA-aEA9cNzd6cJchrdojyX7xKr4eOKECkMEen=fhGucCPA@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=jhanley@dgtlrift.com \
--cc=qemu-devel@nongnu.org \
--cc=vpalatin@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).