From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:58320)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1SCvyJ-0001xT-2c
	for qemu-devel@nongnu.org; Wed, 28 Mar 2012 12:43:48 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1SCvyC-0000kN-WE
	for qemu-devel@nongnu.org; Wed, 28 Mar 2012 12:43:42 -0400
Received: from mail-gy0-f173.google.com ([209.85.160.173]:61760)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1SCvyC-0000kA-Rt
	for qemu-devel@nongnu.org; Wed, 28 Mar 2012 12:43:36 -0400
Received: by ghrr14 with SMTP id r14so1102583ghr.4
	for <qemu-devel@nongnu.org>; Wed, 28 Mar 2012 09:43:33 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <1332944776-4037-1-git-send-email-alevy@redhat.com>
References: <20120328131634.GY32389@garlic>
	<1332944776-4037-1-git-send-email-alevy@redhat.com>
Date: Wed, 28 Mar 2012 17:43:33 +0100
Message-ID: <CAFEAcA-aEpbKOR8hwNzVGPrRkbwdRsYATYjb0v6OwwfeCvJ+kA@mail.gmail.com>
From: Peter Maydell <peter.maydell@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 1/2] tracetool: dtrace: handle in and next
 reserved words
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alon Levy <alevy@redhat.com>
Cc: Stefan Hajnoczi <stefanha@gmail.com>, qemu-devel@nongnu.org, =?UTF-8?Q?Llu=C3=ADs_Vilanova?= <vilanova@ac.upc.edu>

2012/3/28 Alon Levy <alevy@redhat.com>:
> - =C2=A0 =C2=A0 =C2=A0 =C2=A0# 'limit' is a reserved keyword
> - =C2=A0 =C2=A0 =C2=A0 =C2=A0if [ "$arg" =3D "limit" ]; then
> - =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0arg=3D"_limit"
> + =C2=A0 =C2=A0 =C2=A0 =C2=A0# 'limit', 'in' and 'next' are reserved keyw=
ords
> + =C2=A0 =C2=A0 =C2=A0 =C2=A0if [ "$arg" =3D "limit" -o "$arg" =3D "in" -=
o "$arg" =3D "next" ]; then
> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0arg=3D"_$arg"
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 fi

The test -a and -o options are obsolete in POSIX shell scripts
(use "if [ foo ] && [ bar ]" instead).

In this case it would be neater to use 'case' anyway:
    case "$arg" in
        limit|in|next)
            arg=3D"_$arg"
            ;;
    esac

-- PMM